Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holocene: use extraData instead of nonce for eip-1559 parameters #402

Conversation

roberto-bayardo
Copy link
Contributor

@roberto-bayardo roberto-bayardo commented Oct 12, 2024

Description

Use extraData for holocene EIP-1559 parameters so it will be propagated along with the execution payload.

Additional context

Corresponding spec update: ethereum-optimism/specs#428

beacon/engine/types.go Outdated Show resolved Hide resolved
@roberto-bayardo roberto-bayardo force-pushed the eip1559params-in-execution-payload branch from 628e257 to f5f8784 Compare October 14, 2024 21:31
@roberto-bayardo roberto-bayardo requested a review from tynes October 14, 2024 23:47
@tynes
Copy link
Contributor

tynes commented Oct 15, 2024

Definitely most simple to just pass through the encoded params vs having them in a more human readable form. In theory, if there is an update to the serialization, we would be able to use hardfork branching to modify the way they are deserialized

Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@roberto-bayardo
Copy link
Contributor Author

I'm going to change this to use ExecutionPayloadEnvelope as discussed on the call.

@roberto-bayardo
Copy link
Contributor Author

I'm going to change this to use ExecutionPayloadEnvelope as discussed on the call.

Turned out to not be a great solution. Latest plan is to move from nonce to extradata for the params. extraData is already in the execution payload, so it simplifies things a lot. Plus we probably want to use Nonce for sub-second block increments later on.

@roberto-bayardo roberto-bayardo force-pushed the eip1559params-in-execution-payload branch from f5f8784 to 3f90f97 Compare October 15, 2024 23:43
@roberto-bayardo roberto-bayardo changed the title Holocene: add eip1559params field to execution payload Holocene: use extraData instead of nonce for eip-1559 parameters Oct 15, 2024
@roberto-bayardo roberto-bayardo force-pushed the eip1559params-in-execution-payload branch 5 times, most recently from ca75c6a to e271dd1 Compare October 16, 2024 00:05
Copy link
Collaborator

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you update the fork.yaml to describe the changes to the files (also including some prior changes of e.g. introducing EIP1559Params to the payload attributes type)?

consensus/misc/eip1559/eip1559.go Outdated Show resolved Hide resolved
eth/catalyst/api.go Outdated Show resolved Hide resolved
@roberto-bayardo roberto-bayardo force-pushed the eip1559params-in-execution-payload branch from e271dd1 to 7e18f8b Compare October 16, 2024 18:50
@roberto-bayardo
Copy link
Contributor Author

Looks good. Can you update the fork.yaml to describe the changes to the files (also including some prior changes of e.g. introducing EIP1559Params to the payload attributes type)?

yes. ok to do that in another PR? Want to get this in to unblock the op-node reviews

@roberto-bayardo roberto-bayardo force-pushed the eip1559params-in-execution-payload branch 3 times, most recently from 9f0a005 to d2e94b9 Compare October 16, 2024 22:04
@tynes tynes merged commit a7d3295 into ethereum-optimism:optimism Oct 17, 2024
4 of 5 checks passed
@sebastianst
Copy link
Member

Created tag v1.101411.1-rc.1 containing this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants