-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holocene: use extraData instead of nonce for eip-1559 parameters #402
Holocene: use extraData instead of nonce for eip-1559 parameters #402
Conversation
628e257
to
f5f8784
Compare
Definitely most simple to just pass through the encoded params vs having them in a more human readable form. In theory, if there is an update to the serialization, we would be able to use hardfork branching to modify the way they are deserialized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I'm going to change this to use ExecutionPayloadEnvelope as discussed on the call. |
Turned out to not be a great solution. Latest plan is to move from nonce to extradata for the params. extraData is already in the execution payload, so it simplifies things a lot. Plus we probably want to use Nonce for sub-second block increments later on. |
f5f8784
to
3f90f97
Compare
ca75c6a
to
e271dd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can you update the fork.yaml
to describe the changes to the files (also including some prior changes of e.g. introducing EIP1559Params
to the payload attributes type)?
e271dd1
to
7e18f8b
Compare
yes. ok to do that in another PR? Want to get this in to unblock the op-node reviews |
9f0a005
to
d2e94b9
Compare
d2e94b9
to
6c32375
Compare
Created tag |
Description
Use extraData for holocene EIP-1559 parameters so it will be propagated along with the execution payload.
Additional context
Corresponding spec update: ethereum-optimism/specs#428