[AutoPR imagebuilder/resource-manager/v2019_02_01_preview] [Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-05-01-preview #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
…he lease collection documents. (#5508)
* Fixed the setter and getter method
* Convert credential scopes param to TokenRequest * Fix build errors in event hubs * Change .block() to StepVerifier * Fix tests * checkstyle .* imports
* remove java code isImple check but move to suppression and add only check for public class for external Dependency check * fix issue 5113
* Rename from values to getValues()
* Peering: generate 2019 08 01 preview * fix: compile error
* Throw better exceptions in chained token credentials * Fix checkstyle: line too long * Better error message in chained credential * Fix test after new error message
Added File Data Lake package files
* Remove unnessary changes * Added file and samples changes * Minor fix
* Clients and code samples for LeaseClients * Updated tests * Updating unit tests * Using builder pattern for LeaseClients * Fix unit tests * Cleaning up documentation * Fix linting issues and more unit tests * Some moving of clients * Moved test files into correct folder * Moved sub-blob clients to specialized namespace, added BlobBaseClients * Refactoring unit tests * More cleaning up * More cleaning up * Cleaning up linting issues * Addressing PR feedback * Cleaning up Spotbug and linting issues * Updated SpecializedBlobClientBuilder to be a full-fledged builder * Updating CPK variable name and moving specialized test classes to specialized package in test * Cleaning up tests and linting * Fix test order and added exception comment
* Update cosmos versions; up the minor build. * Hot fix version should be 3.2.1
* (Untested) Optimisation for RestProxy createResponse API. * Make the build happy * Introducing LambdaMetaFactory based response cache. * Making LambdaMetaFactory work for Java 9+ * Taking care of concurrent map race * Using singleton MethodType & Signature, using specialized types in function interfaces, replacing Stream with basic loop. * Using singleton MethodHandles.Lookup, adding JMH benchmark for MetaFactory/Reflection * Accomodating removal of core VoidResponse * Adding bench mark for reflection non-cached case * address checkstyle violations in BenchMark tests
* Fix errors caused by upgrading to latest reactor versions * Update netty version to fix failures on linux
* Storage: update 2019 04 01 * Storage: update pom
* remove java code isImple check but move to suppression and add only check for public class for external Dependency check * change enum to ExpandableStringEnum * make it final
* Generating with response models in implementation * Cleaning up model move changes * Moved models to implementation.models * Fix import in unit test * Fix broken test
* Fixing high CPU and memory leak in session pump caused by timed out accept session requests. * Fixing a minor race condition when closing sender or receiver on link creation timeout. * Fixing 2 nit review comments.
…oxy. Instead of teating proxy as the peer, treat the endpoing host as the peer. (#5467)
* Update Blobs download to return deserialized headers * Update Files download to return deserialized headers * Fix build and linting issue * Split response and reliable download into two classes * Fix linting issue, regenerated File swagger to move model class out of implementation * Updated tests to use deserialized headers and reverted accidental class renaming
* Fix naming for MSI credential. * Adding documentation to azure-identity. * Rename MSI -> Msi. * Clarifying documentation.
KV Keys and Secrets API updates
* generate overview from readme for javadocs * move the pip install of markdown2 into an unconditional step * open file with encoding on 2.x needs an import * update the file write to ensure unicode, works for vers 2 & 3 * Update for relative link replacement in readme files * Remove the failed linter experiment from pom.client.xml and update README.md
* readme and changelog text for GA *
* Fix shared token cache lookup * Consistent error message with .net * Better error messages
* Fix up naming of ReliableDownloadOptions methods. * Renaming from ReliableDownloadOptions to DownloadRetryOptions
* Added upload optimization for HTBB * PR feedback * Fixed spotbugs issue * Dang Integers * Checkstyle * Fixed build error * Fixed merge * Fixed build * Fix build * PR feedback * Fixed javadoc code snippet * Fixed some ci stuff * Checkstyle fixes * Removed unused method * Checkstyle and spotbugs * Checkstyle
* Update docs for secrets. * Remove nested subscribe.
* Mockup for upload from file to use upload or stage blocks * Minor changes * Cleanup upload from file logic for full review * Fixed check being used * Cache SwaggerMethodParser for interface in private static * Remove unneccessary comment * Cleanup linting, reduce client retrieval * Fix more linting issues * Cleaned up docuementation and error returns * Updated tests, fixedNPE
…Flux) (#5987) * protyping poller very early draft * some comment fixes * Update LongRunningOperation.java * Update LongRunningOperation.java * Stabilizing prtotype * adding some PollerFlux usecase code in comments * Simplifying API surface of SyncPoller * Update sdk/core/azure-core/src/main/java/com/azure/core/util/polling/AsyncPollResponse.java Co-Authored-By: Jonathan Giles <jonathan@jonathangiles.net> * Adding PollerTests * Incorporating PollerFlux|SyncPoller to storage and keyvault * Adding tests for sync-poller and nullcheck for activationOperation in DefaultSyncPoller * Adding JavaDocCodeSnippets for Poller * More javadoc for poller, better error handling * Making AsyncPollResponse::getRetryAfter package private. * Adding PollingContext for state-mgmt across chain of poll calls & future extensibility (including serialization of poller) * Updating KV certificateClient use poller with context * Adapting key-vault to new Poller * spotbug exclusion for incorrect flagging * Fixing couple of checkstyle errors in poller types * Update storage groovy tests to adapt to new poller * Addressing spotbugs issues in keyvault/storage due to poller adaption * Checkstyle fixes for code-snippet * KV Poller fixes * More checkstyle fixes in keyvault. * addressing review comments on: using FluxUtil.monoError, clone() to copy(), rename exception type and DefaultSyncPoller class level comment on threadsafty. * BlobAPITest:: Moving from sync to async client requires blocking on upload * Re-recording BlobAPI tests * PollerFlux::getBlockingPoller -> getSyncPoller * ensure to unguard if sdk implementer in-correctly throw from activation ops, using volatile response vars in PollingContext and javadoc improvments
Readme changes
* Cut over to GA version.
2 tasks
bump python sdk version to 0.3.0
openapi-sdkautomation
bot
force-pushed
the
sdkAutomation/imagebuilder/resource-manager/v2019_02_01_preview@7655
branch
from
5a9abda
to
48366f5
Compare
|
Hi @openapi-sdkautomation[bot]. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
2 similar comments
|
Hi @openapi-sdkautomation[bot]. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @openapi-sdkautomation[bot]. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @openapi-sdkautomation[bot]. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created to sync Azure/azure-rest-api-specs#7655