Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version preview/2019-05-01-preview #7655

Conversation

feiyushi
Copy link
Contributor

@feiyushi feiyushi commented Oct 28, 2019

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 28, 2019

In Testing, Please Ignore

[Logs] (Generated from 202c280, Iteration 2)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
  • Failed imagebuilder/resource-manager/v2019_02_01_preview [Logs]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • No packages generated.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 29, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6338

@feiyushi
Copy link
Contributor Author

feiyushi commented Nov 4, 2019

@sergey-shandar Please take a look. Thanks

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 8, 2019
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signing off from ARM side. new properties in a preview api-version

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 14, 2019
@AutorestCI
Copy link

AutorestCI commented Nov 14, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#8644

TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
…add version preview/2019-05-01-preview (Azure#7655)

* 1. add vmProfile/vmSize field.
2. change buildTimeoutInMinutes default value to 4h

* fix warnings

* fix format

* 1.add sha256Checksum for shell/powershell customizers and file customizer; 2. powershell run elevated

* bump python sdk version to 0.3.0
@feiyushi feiyushi deleted the dev-imagebuilder-Microsoft.VirtualMachineImages-2019-05-01-preview-2 branch May 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants