Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add testing based on new approach #12

Closed
ingwarr opened this issue Aug 16, 2019 · 2 comments · Fixed by #13
Closed

Add testing based on new approach #12

ingwarr opened this issue Aug 16, 2019 · 2 comments · Fixed by #13
Labels
enhancement New feature or request

Comments

@ingwarr
Copy link

ingwarr commented Aug 16, 2019

As I see CI tests are absent, so we should create it for this module
@morgante
Copy link
Contributor

Agreed. This should be done via Cloud Build though.

@aaron-lane aaron-lane added the enhancement New feature or request label Aug 16, 2019
@aaron-lane aaron-lane changed the title Add CI test for this module Add testing based on new approach Sep 30, 2019
@aaron-lane aaron-lane mentioned this issue Oct 17, 2019
Closed
@milesmatthias milesmatthias self-assigned this Oct 23, 2019
nick4fake added a commit to nick4fake/terraform-google-memorystore that referenced this issue Oct 25, 2019
@nick4fake
Fixes terraform-google-modules#12: Add testing based on new approach
9b731dd 
terraform-google-modules#12

Updated testing.
@nick4fake nick4fake mentioned this issue Oct 25, 2019
Merged
nick4fake added a commit to nick4fake/terraform-google-memorystore that referenced this issue Oct 25, 2019
@nick4fake
Fixes terraform-google-modules#12: Add testing based on new approach
2c61052 
terraform-google-modules#12

Updated testing.
@milesmatthias milesmatthias mentioned this issue Oct 25, 2019
Closed
nick4fake added a commit to nick4fake/terraform-google-memorystore that referenced this issue Oct 28, 2019
@nick4fake
Fixes terraform-google-modules#12: Add testing based on new approach
3191fe0 
terraform-google-modules#12

Updated testing.
nick4fake added a commit to nick4fake/terraform-google-memorystore that referenced this issue Oct 28, 2019
@nick4fake
Fixes terraform-google-modules#12: Add testing based on new approach
3b99ad4 
terraform-google-modules#12

Updated testing.
nick4fake added a commit to nick4fake/terraform-google-memorystore that referenced this issue Oct 28, 2019
@nick4fake
Fixes terraform-google-modules#12: Add testing based on new approach
b1e761d 
terraform-google-modules#12

Updated testing.
@nick4fake
Copy link
Contributor

@morgante PR 13 has CI/CD passing, so you can merge it.

nick4fake added a commit to nick4fake/terraform-google-memorystore that referenced this issue Oct 28, 2019
@nick4fake
Fixes terraform-google-modules#12: Add testing based on new approach
1343210 
terraform-google-modules#12

Updated testing.
morgante added a commit that referenced this issue Oct 28, 2019
@morgante
Merge pull request #13 from nick4fake/fix/12
92c0731 
#12: Add testing based on new approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
5 participants
@milesmatthias @nick4fake @morgante @ingwarr @aaron-lane