Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added outputs for generated iam_role resource. #35

Closed
wants to merge 9 commits into from
Closed

Added outputs for generated iam_role resource. #35

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1baab7e
Added iam_role_arn output
nielsdraaisma Apr 10, 2018
a9c919d
Reformatted iam_role_arn to map instead of string
nielsdraaisma Apr 10, 2018
42e1d8f
Renamed iam_role output name
nielsdraaisma Apr 10, 2018
05031a3
Update README.md
nielsdraaisma Apr 10, 2018
8a7bb58
Update README.md
nielsdraaisma Apr 10, 2018
3ce8483
Fixed formatting
nielsdraaisma Apr 10, 2018
bcf0104
Changed count check in aws_iam_policy.ecs_policy
nielsdraaisma May 1, 2018
7e8f98e
Ensured both normal and custom ecs policies are attached to the iam role
nielsdraaisma May 1, 2018
8f82887
Ensured both normal and custom ecs policies are attached to the iam role
nielsdraaisma May 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changed count check in aws_iam_policy.ecs_policy
  • Loading branch information
@nielsdraaisma
nielsdraaisma committed May 1, 2018
commit bcf01043ecc69ff18adc485b38f978d8a6f4a23e
2 changes: 0 additions & 2 deletions iam.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ resource "aws_iam_policy" "ecs_policy" {
name_prefix = "${replace(format("%.102s", replace("tf-ECSInPol-${var.name}-", "_", "-")), "/\\s/", "-")}"
description = "A terraform created policy for ECS"
path = "${var.iam_path}"
count = "${length(var.custom_iam_policy) > 0 ? 0 : 1}"

policy = <<EOF
{
Expand Down Expand Up @@ -69,7 +68,6 @@ resource "aws_iam_policy" "custom_ecs_policy" {
name_prefix = "${replace(format("%.102s", replace("tf-ECSInPol-${var.name}-", "_", "-")), "/\\s/", "-")}"
description = "A terraform created policy for ECS"
path = "${var.iam_path}"
count = "${length(var.custom_iam_policy) > 0 ? 1 : 0}"

policy = "${var.custom_iam_policy}"
}
Expand Down
1 change: 1 addition & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ variable "iam_path" {
variable "custom_iam_policy" {
default = ""
description = "Custom IAM policy (JSON). If set will overwrite the default one"
default = ""
}

variable "instance_type" {
Expand Down