Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added outputs for generated iam_role resource. #35

Closed

Conversation

nielsdraaisma
Copy link

This PR exposes the arn/name of the iam_role which is created by this module.

@nielsdraaisma nielsdraaisma changed the title Added outputs for generate iam_role resource. Added outputs for generated iam_role resource. Apr 10, 2018
@tfhartmann
Copy link
Member

Please accept my apologies for the delay in review on this.
I like the idea of adding the outputs, but this PR looks like it effectively reverts #26 Can I suggest rather then removing the logic for using a custom IAM policy you add a conditional to the output so that it only fires if the module creates the policy? Basically, I'm concerned with potentially loosing a feature of the module. It's also possible that I just misread the diff too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants