-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin rules_closure to commit c56b953 #6770
Changes from all commits
1b70c79
739ac0b
cc88b27
7f48760
562677c
8de957f
c0075d6
04c541b
29ae219
ae27f1e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,19 +24,18 @@ versions.check( | |
minimum_bazel_version = "4.2.2", | ||
) | ||
|
||
# Use the same rules_webtesting version required by rules_closure: | ||
# https://github.com/bazelbuild/rules_closure/blob/c56b953045c883b393d6f0f5dbf9900df71949c1/closure/repositories.bzl#L1099 | ||
http_archive( | ||
name = "io_bazel_rules_webtesting", | ||
sha256 = "9bb461d5ef08e850025480bab185fd269242d4e533bca75bfb748001ceb343c3", | ||
sha256 = "41d500a97ad9621dcf92fcb0cd77916e517388b196e5c3f0e63c7753e983b2bb", | ||
strip_prefix = "rules_webtesting-4d7ec75d1cbb289f977b41638fc8b630bdf22bee", | ||
urls = [ | ||
"http://mirror.tensorflow.org/github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz", | ||
"https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz", | ||
"http://mirror.tensorflow.org/github.com/bazelbuild/rules_webtesting/archive/4d7ec75d1cbb289f977b41638fc8b630bdf22bee.tar.gz", | ||
"https://github.com/bazelbuild/rules_webtesting/archive/4d7ec75d1cbb289f977b41638fc8b630bdf22bee.tar.gz", | ||
], | ||
) | ||
|
||
load("@io_bazel_rules_webtesting//web:repositories.bzl", "web_test_repositories") | ||
|
||
web_test_repositories(omit_bazel_skylib = True) | ||
|
||
# rules_python has to be placed before load("@io_bazel_rules_closure//closure:repositories.bzl") | ||
# in the dependencies list, otherwise we get "cannot load '@rules_python//python:py_xxx.bzl': no such file" | ||
http_archive( | ||
|
@@ -55,11 +54,13 @@ py_repositories() | |
|
||
http_archive( | ||
name = "io_bazel_rules_closure", | ||
sha256 = "6a900831c1eb8dbfc9d6879b5820fd614d4ea1db180eb5ff8aedcb75ee747c1f", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks, Yating! One question... how do we get these values? Should we just comment them out? Or is it easy to return to this if we need to? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just ran the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, but how about the urls? Where/how did you find this new value to reference? Is there a guide for how to update these references? Is it just that these particular versions are the latest ones available at http://mirror.tensorflow.org? |
||
strip_prefix = "rules_closure-db4683a2a1836ac8e265804ca5fa31852395185b", | ||
sha256 = "b2ead8bdcf6d2d56b9cb797699a0ea707d33998edb9067825a588d9ccd3805e0", | ||
# Temporarily pin to this commit to unblock go/tbpr/6721: https://github.com/bazelbuild/rules_closure/pull/599 | ||
# TODO: b/327605070 - Unpin this. | ||
strip_prefix = "rules_closure-c56b953045c883b393d6f0f5dbf9900df71949c1", | ||
urls = [ | ||
"http://mirror.tensorflow.org/github.com/bazelbuild/rules_closure/archive/db4683a2a1836ac8e265804ca5fa31852395185b.tar.gz", | ||
"https://github.com/bazelbuild/rules_closure/archive/db4683a2a1836ac8e265804ca5fa31852395185b.tar.gz", # 2020-01-15 | ||
"http://mirror.tensorflow.org/github.com/bazelbuild/rules_closure/archive/c56b953045c883b393d6f0f5dbf9900df71949c1.tar.gz", | ||
"https://github.com/bazelbuild/rules_closure/archive/c56b953045c883b393d6f0f5dbf9900df71949c1.tar.gz", # 2024-02-28 | ||
], | ||
) | ||
|
||
|
@@ -71,6 +72,10 @@ rules_closure_dependencies( | |
omit_com_google_protobuf_js = True, | ||
) | ||
|
||
load("@io_bazel_rules_closure//closure:defs.bzl", "setup_web_test_repositories") | ||
|
||
setup_web_test_repositories(chromium=True) | ||
|
||
http_archive( | ||
name = "build_bazel_rules_nodejs", | ||
sha256 = "c29944ba9b0b430aadcaf3bf2570fece6fc5ebfb76df145c6cdad40d65c20811", | ||
|
@@ -176,9 +181,14 @@ load("@com_github_grpc_grpc//bazel:grpc_deps.bzl", "grpc_deps") | |
|
||
grpc_deps() | ||
|
||
load("@com_github_grpc_grpc//bazel:grpc_extra_deps.bzl", "grpc_extra_deps") | ||
|
||
grpc_extra_deps() | ||
http_archive( | ||
name = "build_bazel_rules_swift", | ||
sha256 = "32f95dbe6a88eb298aaa790f05065434f32a662c65ec0a6aabdaf6881e4f169f", | ||
urls = [ | ||
"http://mirror.tensorflow.org/github.com/bazelbuild/rules_swift/releases/download/1.5.0/rules_swift.1.5.0.tar.gz", | ||
"https://github.com/bazelbuild/rules_swift/releases/download/1.5.0/rules_swift.1.5.0.tar.gz", | ||
], | ||
) | ||
|
||
http_archive( | ||
name = "rules_rust", | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of the issues we encountered with
platform_http_file
andweb_test_archive
rules being removed are due to this change.But I don't understand why we're changing this reference... I thought we only had to pin the one below, related to "closure" rules.
And I don't understand what version/snapshot we are referencing here. (Maybe we should add a comment?)
I suppose it's fine to update it, and we'll need to make these changes whenever we do, anyway... But I think we could make these changes independently. Or is there a reason to make them together?