-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin rules_closure to commit c56b953 #6770
Conversation
@@ -55,11 +55,13 @@ py_repositories() | |||
|
|||
http_archive( | |||
name = "io_bazel_rules_closure", | |||
sha256 = "6a900831c1eb8dbfc9d6879b5820fd614d4ea1db180eb5ff8aedcb75ee747c1f", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Yating!
One question... how do we get these values? Should we just comment them out? Or is it easy to return to this if we need to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran the shasum -a 256
against the tar.gz
file, I think we always update the commit hash when we change version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but how about the urls? Where/how did you find this new value to reference? Is there a guide for how to update these references?
Is it just that these particular versions are the latest ones available at http://mirror.tensorflow.org?
urls = [ | ||
"http://mirror.tensorflow.org/github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz", | ||
"https://github.com/bazelbuild/rules_webtesting/releases/download/0.3.3/rules_webtesting.tar.gz", | ||
"http://mirror.tensorflow.org/github.com/bazelbuild/rules_webtesting/archive/4d7ec75d1cbb289f977b41638fc8b630bdf22bee.tar.gz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all of the issues we encountered with platform_http_file
and web_test_archive
rules being removed are due to this change.
But I don't understand why we're changing this reference... I thought we only had to pin the one below, related to "closure" rules.
And I don't understand what version/snapshot we are referencing here. (Maybe we should add a comment?)
I suppose it's fine to update it, and we'll need to make these changes whenever we do, anyway... But I think we could make these changes independently. Or is there a reason to make them together?
@@ -55,11 +55,13 @@ py_repositories() | |||
|
|||
http_archive( | |||
name = "io_bazel_rules_closure", | |||
sha256 = "6a900831c1eb8dbfc9d6879b5820fd614d4ea1db180eb5ff8aedcb75ee747c1f", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but how about the urls? Where/how did you find this new value to reference? Is there a guide for how to update these references?
Is it just that these particular versions are the latest ones available at http://mirror.tensorflow.org?
…mespace is now auto-imported by `rules_closure`
… conflict with `rules_webtesting`
Pin to bazelbuild/rules_closure#599 in order to unblock #6721. Note that this
rule_closure
commit uses a specificrules_webtesting
version, which has ago_register_toolchains
version conflict withgrpc_extra_deps
:rules_webtesting
specifies version1.20.5
grpc_extra_deps
uses version1.18
The only thing we need that is installed by
grpc_extra_deps
isrules_swift
, addedbuild_bazel_rules_swift
directly in order to removegrpc_extra_deps
.Googlers, see cl/597800285 and b/327605070 for context.
#oncall