Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projector Plugin: Bookmark loading is broken #4159

Closed
aknoerig opened this issue Sep 14, 2020 · 0 comments · Fixed by #4160
Closed

Projector Plugin: Bookmark loading is broken #4159

aknoerig opened this issue Sep 14, 2020 · 0 comments · Fixed by #4160

Comments

@aknoerig
Copy link
Contributor

Environment information (required)

I am using the standalone build of the projector plugin from master.

  • bazel 2.1.0
  • Chrome 85.0.4183.102

Issue description

In the projector plugin, the selected bookmark fails to load.

Steps to recreate:

  1. Build the projector plugin using the standalone target
  2. Open in browser
  3. Switch to the "Word2Vec All" sample dataset
  4. Select the sample bookmark "Politics: Bad to Good"

Console output:

Uncaught TypeError: evt.path[i].getAttribute is not a function
    at HTMLElement.getParentDataIndex (vz-projector-inspector-panel.mjs:404)
    at HTMLElement._radioButtonHandler (vz-projector-inspector-panel.mjs:377)
    at handler (apply-shim.js:264)
    at HTMLElement.<anonymous> (iron-a11y-keys-behavior.js:295)
    at _fire (dom-if.js:63)
    at trackForward (dom-if.js:444)
    at Object.click (dom-if.js:403)
    at HTMLElement._handleNative (dom-repeat.js:644)

Probably this is another side-effect of the recent upgrade to Polymer3?

aknoerig added a commit to aknoerig/tensorboard that referenced this issue Sep 14, 2020
Bookmark loading currently fails because of a missing type check. This change makes sure the object that is checked against is actually an HTMLElement.
@rmothukuru rmothukuru self-assigned this Sep 15, 2020
@rmothukuru rmothukuru linked a pull request Sep 15, 2020 that will close this issue
psybuzz pushed a commit that referenced this issue Oct 14, 2020
Bookmark loading currently fails because of a missing type check.
This change makes sure the object that is checked against is actually
an HTMLElement.

See #4159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants