Projector Plugin: Fix bookmark loading (issue tensorflow#4159)

Bookmark loading currently fails because of a missing type check. This change makes sure the object that is checked against is actually an HTMLElement.
aknoerig · Sep 14, 2020 · 6e0a216 · 6e0a216
1 parent 8a8788c
commit 6e0a216
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/tensorboard/plugins/projector/vz_projector/vz-projector-bookmark-panel.ts b/tensorboard/plugins/projector/vz_projector/vz-projector-bookmark-panel.ts
@@ -197,9 +197,12 @@ class BookmarkPanel extends LegacyElementMixin(PolymerElement) {
    */
   private getParentDataIndex(evt: Event) {
     for (let i = 0; i < (evt as any).path.length; i++) {
-      let dataIndex = (evt as any).path[i].getAttribute('data-index');
-      if (dataIndex != null) {
-        return +dataIndex;
+      let elem = (evt as any).path[i];
+      if (elem instanceof HTMLElement) {
+        let dataIndex = elem.getAttribute('data-index');
+        if (dataIndex != null) {
+          return +dataIndex;
+        }
       }
     }
     return -1;