Update Nix integration #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let Stack generate the nix-shell internally instead of writing it manually.
The previous snapshot contained a libtensorflow version that did not match the third_party/tensorflow submodule version.
Minnozz
force-pushed
the
update-nix-integration
branch
from
30872f4 to
7d7a07b
Compare
fkm3
approved these changes
Jan 17, 2023
|
@fkm3 I'm not sure how to interpret the CI status; is this waiting on something internally at Google? |
|
Turns out our CI is broken. I've sent out a fix. Hopefully will be working tomorrow and then I'll get these PRs merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let Stack generate the nix-shell internally instead of writing it manually.
The previous snapshot contained a libtensorflow version that did not match the
third_party/tensorflowsubmodule version.stack --nix testsucceeds