-
Notifications
You must be signed in to change notification settings - Fork 200
Update to TensorFlow 2.10.1 #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bdaa6e1
to
12ac796
Compare
I'm not a user of TensorFlow; I updated these bindings for a colleague who needed the SavedModel functionality. |
Thanks for the PR, I'll try to review soon. |
I'm seeing some failures in This PR does a couple things
I know sometimes things needs to happen together, but could you separate out at least the new feature (SavedModel support) if possible. |
Yes, I see those too. I can't find any test output that indicates what's going wrong, so I'm not sure how to debug this further.
Yes, now that I have a (mostly) working version I'll try to separate things out some more. SavedModel support depends on the new TF version (for TF_LoadSessionFromSavedModel) and on TF_Session (which is used by TF_LoadSessionFromSavedModel). I'll try to see if the new GHC and Stack versions are still required (it was one of the first things I tried to solve a compilation error). |
@fkm3 Is there a way you would like to receive sequential PRs or should I wait with submitting the next one until the previous one is merged? |
39f0a8e
to
12f618f
Compare
@fkm3 I split out the original PR into multiple PRs (in merge order):
Updating the Stackage / GHC version turns out to not be necessary. I could use some help with updating the byte layout of string tensors, which is the reason the |
Thanks!
I'll try to figure it out. Thanks for narrowing it down |
https://github.com/tensorflow/community/blob/master/rfcs/20190411-string-unification.md Example of the conversion in the Go and Java bindings: tensorflow/tensorflow@24f8352 |
7abdbbf
to
c5bfff9
Compare
I think I've got a working solution at 63753cc. Can you cherry pick that CL into this PR? (I either don't have permissions to push to this or I am doing it wrong) |
c5bfff9
to
8da638f
Compare
@fkm3 Thanks for implementing the new TF_STRING format! I've replaced my placeholder commit with yours. |
8da638f
to
5e2bd5a
Compare
My remaining question is whether all the protos I added should be generated or if some of them are considered internal. |
I'm not sure. We could look at the For the sake of compile times, it would be best to only add what we need. Not a blocker though, we can always trim it later and build time wise other parts of the library are much worse (I can't believe how slow this project builds, not sure if it was always this bad or if something regressed). |
There is a build error. It is my fault, forgot to test my commit with
Do you mind amending it to delete those two imports? |
5e2bd5a
to
07ed761
Compare
Thanks for the PR, first TF version update in over 2 years! |
docker/
andci_build/
totensorflow/tensorflow:2.10.1
stack --docker test
succeedslibtensorflow
2.10.1stack --nix test
succeeds(breaking change; fixes
QueueTest
intensorflow-ops
)