Skip to content

Fix compatibility with tensorflow 1.14.0 #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 15, 2019

Conversation

yorickvP
Copy link
Contributor

This blacklists all the ops that use 'func'. Long term it might be better to support it.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yorickvP
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@blackgnezdo
Copy link
Contributor

Could you update a few more files where we have the version baked-in? Unfortunately it is duplicated:
ecfea97

@yorickvP
Copy link
Contributor Author

I think that's all of them!

Copy link
Contributor

@blackgnezdo blackgnezdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@yorickvP
Copy link
Contributor Author

I can't see why the build fails, the details page is on an internal network.

@blackgnezdo
Copy link
Contributor

I guess they pruned the image. Could you add curl?

Processing triggers for libc-bin (2.23-0ubuntu11) ...
/bin/sh: 1: curl: not found
The command '/bin/sh -c apt-key adv --keyserver hkp://keyserver.ubuntu.com:80 --recv-keys 575159689BEFB442 &&     apt-get update &&     apt-get install -y         libsnappy-dev         libncurses5-dev         libgmp-dev         libcurl3-dev         netbase         &&     curl -O -L https://github.com/commercialhaskell/stack/releases/download/v1.7.1/stack-1.7.1-linux-x86_64.tar.gz &&     tar zxf stack-1.7.1-linux-x86_64.tar.gz -C /usr/local/bin stack-1.7.1-linux-x86_64/stack --strip 1 &&     curl -O -L https://github.com/google/protobuf/releases/download/v3.2.0/protoc-3.2.0-linux-x86_64.zip &&     unzip -d /usr/local protoc-3.2.0-linux-x86_64.zip bin/protoc &&     chmod 755 /usr/local/bin/protoc &&     curl -O https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-linux-x86_64-1.13.1.tar.gz &&     tar zxf libtensorflow-cpu-linux-x86_64-1.13.1.tar.gz -C /usr/local &&     ldconfig &&     stack setup &&     stack test --only-dependencies' returned a non-zero code: 127
[ID: 7243153] Build finished after 80 secs, exit value: 127

@yorickvP
Copy link
Contributor Author

Curl has been added. Since 1.14 is out, maybe I'll update everything to that.

@yorickvP yorickvP changed the title Fix compatibility with tensorflow 1.13.1 Fix compatibility with tensorflow 1.14.0 Jun 30, 2019
@vilunov
Copy link

vilunov commented Jul 12, 2019

@blackgnezdo Hi! Sorry to bother, but are there any problems with this PR? CI seems to be stuck

@blackgnezdo
Copy link
Contributor

Apologies, if the build goes through, @fkm3 or @judah could you merge this?

@fkm3
Copy link
Contributor

fkm3 commented Jul 12, 2019

I guess they really pruned down the image. The current error is

/bin/sh: 1: unzip: not found

If you've got a docker setup locally, you should be able to run the follow command to reproduce the error.

ci_build/outer_launch_tests.sh

@vilunov
Copy link

vilunov commented Jul 12, 2019

Another dependency you need is zlib1g-dev, without it the stack build fails

@fkm3
Copy link
Contributor

fkm3 commented Jul 12, 2019

Yeah. I just got a successful run of the CI tests locally by adding both unzip and zlib1g-dev to the Dockerfiles.

@blackgnezdo
Copy link
Contributor

@fkm3 could you check what's broken now?

@vilunov
Copy link

vilunov commented Jul 15, 2019 via email

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@blackgnezdo
Copy link
Contributor

@yorickvP seems you forgot a \ symbol at the end of the line in some of dockerfiles

Thanks @vilunov, let's see if I can make it go through.

@blackgnezdo blackgnezdo merged commit 26eebce into tensorflow:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants