-
Notifications
You must be signed in to change notification settings - Fork 200
Fix compatibility with tensorflow 1.14.0 #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Could you update a few more files where we have the version baked-in? Unfortunately it is duplicated: |
I think that's all of them! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
I can't see why the build fails, the details page is on an internal network. |
I guess they pruned the image. Could you add curl?
|
Curl has been added. Since 1.14 is out, maybe I'll update everything to that. |
@blackgnezdo Hi! Sorry to bother, but are there any problems with this PR? CI seems to be stuck |
I guess they really pruned down the image. The current error is
If you've got a docker setup locally, you should be able to run the follow command to reproduce the error.
|
Another dependency you need is |
Yeah. I just got a successful run of the CI tests locally by adding both |
@fkm3 could you check what's broken now? |
@yorickvP seems you forgot a `\` symbol at the end of the line in some of
dockerfiles
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
This blacklists all the ops that use 'func'. Long term it might be better to support it.