Support tensorflow 1.10 ?

[jyp]

I tried to compile the package on the basis of nixos master branch, and got:

parseAttrType: unrecognized type "func" for op "BatchFunction"
CallStack (from HasCallStack):
  error, called at src/TensorFlow/OpGen/ParsedOp.hs:342:10 in tensorflow-opgen-0.2.0.0-1UpNHobsfgjGI7NFMU58sK:TensorFlow.OpGen.ParsedOp

I am suspecting that this is due to tensorflow haskell not supporting tensorflow 1.10.
Is this a correct assessment? If so, any plans to support version 1.10?

[blackgnezdo]

@jyp, please take a look at the commit for 1.9 upgrade. The failing function in question should probably be blacklisted.

[jyp]

@blackgnezdo I can't make sense of your message. I am talking about supporting 1.10, I don't see anything related to that in the commit for 1.9. I don't know what "the function in question is" and I don't know what blacklisting means. The commit does not seem to give any hint regarding that.

[blackgnezdo]

If you make a commit similar to the one I pointed at you can upgrade us to 1.10. There's a change to Setup.hs where the blackList variable is extended. You will need to add "BatchFunction" to that list.

Is this helpful?

[jyp]

@blackgnezdo Thanks, that is clear. I will probably not work on this in the short term though.

[teto]

This patch

diff --git b/Setup.hs a/Setup.hs
index 9a5b036..9749de8 100644
--- b/Setup.hs
+++ a/Setup.hs
@@ -91,6 +91,8 @@ fudgePackageDesc lbi p = p
 blackList =
     [ -- Requires the "func" type:
       "FilterDataset"
+    , "BatchFunction"
+    , "StatefulPartitionedCall"
     , "FlatMapDataset"
     , "For"
     , "GeneratorDataset"

with this overlay

  haskell = prev.haskell // {
    packageOverrides = hself: hprev: rec {  

      zeromq4-haskell = prev.haskell.lib.dontCheck hprev.zeromq4-haskell;

      tensorflow-core-ops = prev.haskell.lib.appendPatch (hprev.tensorflow-core-ops) ../../tensorflow.patch;
    };
  };

seems to do it.

[teto]

(related #215)

[cdepillabout]

tensorflow haskell has recently been updated to support TensorFlow 1.14, so this issue can probably be closed:

#244