Skip to content

Commit

Permalink
Reworded plugin frontend binary text
Browse files Browse the repository at this point in the history
  • Loading branch information
stephanwlee committed May 17, 2019
1 parent d778a61 commit d1b08b5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rfcs/20190411-tensorboard-improved-plugin-ext.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Despite the benefits and its simplicity, Colab makes this solution more complex
### Frontend binary
Vulcanization today does not support CommonJS or packages from NPM. The team recognizes it to be an impediment for a plugin authorship and is unnatural for developing a frontend. TensorBoard team will provide a canonical build configuration that uses bazelbuild/rules_nodejs and Rollup but will not inhibit one from using Webpack and other bundlers.

A frontend binary will be a self evaluating JavaScript. With exceptions of Polymer1 and Polymer2, modern frameworks and libraries either use JavaScript or a JavaScript based template system to create a DOM or a WebComponent and, thus, the requirement should be easy to fulfill. To support legacy Polymer versions, we can consider taking a HTML as the format for the binary but this is not robust to different binary loading strategies discussed above, especially given deprecated [HTML import](https://developer.mozilla.org/en-US/docs/Web/Web_Components/HTML_Imports).
The frontend binary will be a collection JavaScript modules that implements certain interface -- one for configuring the dashboard (registerDashboard) and another for render. With exceptions of Polymer1 and Polymer2, modern frameworks and libraries either use JavaScript or a JavaScript based template system to create a DOM or a WebComponent and, thus, the requirement should be easy to fulfill.

### Core module and UI/UX Consistency
One of the most important key concepts when using TensorBoard is the data selection. TensorBoard uses runs and tags to filter potentially a large set of event logs to visualize. Most plugins implemented this today and we expect third party plugins to do the same.
Expand Down

0 comments on commit d1b08b5

Please sign in to comment.