Skip to content

Commit

Permalink
Wording changed
Browse files Browse the repository at this point in the history
  • Loading branch information
stephanwlee committed May 17, 2019
1 parent 6fd3bdb commit d778a61
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rfcs/20190411-tensorboard-improved-plugin-ext.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Iframe sandboxes JavaScript context and it gives plugin developers a lot of free

It must be clearly stated that the use of global state is not unique to Polymer. Although JavaScript bundles use Immediately Invoked Function Expression (IIFE) and use closure to encapsulate dependencies, a bundler like Browserify or Webpack _can_ uses global states when shimming CommonJS `window.require` and use non-unique identifier for a global module.

Despite the benefits and its simplicity, Colab does make this solution a bit trickier. Because frames with different origin cannot be intercepted by Colab's ServiceWorker, it would require some mechanism to route request to the non-publicly exposed server running the kernel. The TensorBoard team is working with Colab to introduce new API that would allows a port to be "exposed" to a stable URL (actual behavior is a lot more complex and is subject to changes). The team is confident thatTensorBoard can work around the iframe issue using this URL.
Despite the benefits and its simplicity, Colab makes this solution more complex -- because frames with different origins cannot be intercepted by Colab's ServiceWorker, we need some mechanism to route request to the non-publicly visible server running on the kernel. The TensorBoard team is working with Colab to introduce new Colab API that allows a port to be "exposed" to a stable URL (actual behavior is a lot more complex and is subject to changes) and the team is confident that it will make the iframe solution compatible with Colab.

### Frontend binary
Vulcanization today does not support CommonJS or packages from NPM. The team recognizes it to be an impediment for a plugin authorship and is unnatural for developing a frontend. TensorBoard team will provide a canonical build configuration that uses bazelbuild/rules_nodejs and Rollup but will not inhibit one from using Webpack and other bundlers.
Expand Down

0 comments on commit d778a61

Please sign in to comment.