Skip to content

[Backport r0.8] Fix label of macos version in wheels #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bot-of-gabrieldemarmiesse

Backport f78818c from #1119

@bot-of-gabrieldemarmiesse bot-of-gabrieldemarmiesse requested a review from a team as a code owner February 21, 2020 15:37
@boring-cyborg boring-cyborg bot added the build label Feb 21, 2020
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@gabrieldemarmiesse
Copy link
Member

@seanpmorgan I'll let you merge when you think it's ok.

Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. Merging.

@seanpmorgan seanpmorgan merged commit 2ce92ab into tensorflow:r0.8 Feb 22, 2020
@tmbo
Copy link

tmbo commented Mar 4, 2020

Any reason why it is not possible to tag a patch for 0.8? The nightlies work fine, but lots of people still use osx 10.14 so it is quite a pain.

@seanpmorgan
Copy link
Member

Any reason why it is not possible to tag a patch for 0.8? The nightlies work fine, but lots of people still use osx 10.14 so it is quite a pain.

No reason sorry about that. I was going to bring it up at our monthly meeting, but seems like there is an active use case. Will publish 0.8.3 shortly.

@tmbo
Copy link

tmbo commented Mar 4, 2020

Thanks a lot, very appreciated - we didn't notice this either but users of our library are running into this more and more now 😅

@seanpmorgan
Copy link
Member

@tmbo 0.8.3 is now available

@tmbo
Copy link

tmbo commented Mar 4, 2020

Thanks so much for jumping on this. Enjoy your day 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants