Fix label of macos version in wheels #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpmorgan
changed the title
seanpmorgan
added
blocked
seanpmorgan
changed the title
seanpmorgan
changed the title
|
@tensorflow/sig-addons-maintainers Fixed this. PTAL when time allows. |
gabrieldemarmiesse
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
Looks correct, this should become easier to merge PRs like this once #1122 is fixed.
|
Should this have been backported? |
Ah yeah it should have. I think let's just make sure it works on today's nightly and then we can do it manually. |
gabrieldemarmiesse
added
the
backport r0.8
jrruijli
pushed a commit
to jrruijli/addons
that referenced
this pull request
Dec 23, 2020
* Fix labeled of macos wheels * Update plat version * Fix string building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1108