Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor the envd and up cmd #747

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

aseaday
Copy link
Member

@aseaday aseaday commented Aug 9, 2022

Signed-off-by: nullday aseaday@hotmail.com

Signed-off-by: nullday <aseaday@hotmail.com>
@kemingy kemingy linked an issue Aug 11, 2022 that may be closed by this pull request
@kemingy
Copy link
Member

kemingy commented Aug 11, 2022

@aseaday
Copy link
Member Author

aseaday commented Aug 11, 2022

No problem, I am working on it and wil have it fixed today. A headache happend to me yesterday.

@kemingy
Copy link
Member

kemingy commented Aug 11, 2022

No problem, I am working on it and wil have it fixed today. A headache happend to me yesterday.

Take care and take your time, not an urgent task.

Signed-off-by: nullday <aseaday@hotmail.com>
Signed-off-by: nullday <aseaday@hotmail.com>
@aseaday aseaday changed the title WIP: refactor the envd and up cmd chore: refactor the envd and up cmd Aug 11, 2022
@aseaday aseaday requested review from gaocegege and kemingy August 11, 2022 16:23
@gaocegege
Copy link
Member

/assign @kemingy

Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@kemingy kemingy merged commit 4f24b0e into tensorchord:main Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: refactor the cmd build and up
3 participants