bug(CLI): fail to use both path and file flag in envd up

[gaocegege]

envd up --path ./examples/mnist -f ./examples/mnist/build_gpu.envd 
error: no such file or directory

We use the path dir as the cwd, thus we cannot find the file ./examples/mnist/build_gpu.envd

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

[popfido]

We can recording pwd as a global 'ENV_DIR' to support both path dir and the current dir.

Is it suitable?

[gaocegege]

We can recording pwd as a global 'ENV_DIR' to support both path dir and the current dir.

Is it suitable?

Could you please explain more about it?

[popfido]

We can recording pwd as a global 'ENV_DIR' to support both path dir and the current dir.
Is it suitable?

Could you please explain more about it?

Just record the current working dir by using pwd() path as a secondary base search path when it is failed in using the path dir to find the file with-f.

[gaocegege]

Gotcha, SGTM. I think it works.

[kemingy]

Is there a bug in

envd/pkg/builder/util.go

Lines 321 to 338 in 53d8e13

	func ParseFromStr(fromStr string) (string, string, error) {
	filename := defaultFile
	funcname := defaultFunc
	if strings.Contains(fromStr, ":") {
	fromArr := strings.Split(fromStr, ":")
	if len(fromArr) != 2 {
	return "", "", errors.New("invalid from format, expected `file:func`")
	}
	if fromArr[0] != "" {
	filename = fromArr[0]
	}
	if fromArr[1] != "" {
	funcname = fromArr[1]
	}
	}
	return filename, funcname, nil
	}

So no matter what you pass to -f, it will always use the defaultbuild.envd. (Unless you specify the target function)

BTW, the -f description is "Function to execute, format file:func". Should we use filepath.Base() to extract the last element?

[gaocegege]

I think it is a bug.