Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter #376

Merged
merged 6 commits into from
Jun 8, 2021
Merged

Add linter #376

merged 6 commits into from
Jun 8, 2021

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 31, 2021


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@alessio alessio requested a review from dongsam May 31, 2021 04:53
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #376 (76d6891) into develop (634a84f) will increase coverage by 0.06%.
The diff coverage is 85.98%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #376      +/-   ##
===========================================
+ Coverage    82.45%   82.52%   +0.06%     
===========================================
  Files           20       20              
  Lines         2286     2283       -3     
===========================================
- Hits          1885     1884       -1     
+ Misses         228      226       -2     
  Partials       173      173              
Impacted Files Coverage Δ
x/liquidity/types/params.go 98.43% <ø> (ø)
x/liquidity/keeper/invariants.go 60.38% <42.85%> (ø)
x/liquidity/types/swap.go 78.32% <82.75%> (+0.48%) ⬆️
x/liquidity/keeper/store.go 88.23% <83.78%> (ø)
x/liquidity/keeper/liquidity_pool.go 80.24% <100.00%> (ø)
x/liquidity/keeper/swap.go 63.09% <100.00%> (ø)
x/liquidity/simulation/operations.go 75.09% <100.00%> (ø)
x/liquidity/types/keys.go 100.00% <100.00%> (ø)
x/liquidity/types/liquidity_pool.go 97.26% <100.00%> (ø)
x/liquidity/types/msgs.go 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d626790...76d6891. Read the comment docs.

@jaybxyz jaybxyz added the devops installation, deployment, node operation label Jun 2, 2021
@dongsam
Copy link
Contributor

dongsam commented Jun 2, 2021

Thank you for the PR! @alessio

As discussed in cosmos/cosmos-sdk#7032, some of the Lint is broken by keeping the variable names of the PascalCase (...Id) automatically generated by the grpc-gateway. Is it okay to exclude these parts from the Lint?

examples

  • Error: var poolId should be poolID (golint)
  • Error: method parameter poolId should be poolID (golint)
  • Error: func parameter swapTypeId should be swapTypeID (golint)
  • Error: const DefaultPoolTypeId should be DefaultPoolTypeID (golint)
  • ...

@alessio
Copy link
Contributor Author

alessio commented Jun 2, 2021

Is it okay to exclude these parts from the Lint?

Of course it is! I'd recommend adding all relevant //nolint:$LINTER 👍

@hallazzang
Copy link
Contributor

@alessio I'm currently working on resolving linter issues!

@dongsam dongsam merged commit e47b7af into develop Jun 8, 2021
@alessio
Copy link
Contributor Author

alessio commented Jun 8, 2021

Thank you so very much! 🙏🏻

@alessio alessio deleted the alessio/add-linter branch June 8, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops installation, deployment, node operation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants