Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between constant/variable names #411

Closed
hallazzang opened this issue Jun 14, 2021 · 1 comment
Closed

Inconsistency between constant/variable names #411

hallazzang opened this issue Jun 14, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@hallazzang
Copy link
Contributor

As a result of #376, we have converted Id to ID except for proto-related fields.
But as x/liquidity/types/events.go has nolint flag, the file was not covered by the conversion:

GlobalLiquidityPoolIDKey = []byte("globalLiquidityPoolId")

AttributeValuePoolId = "pool_id"

To keep the convention consistent, and as far as we decided to use Id for proto files, it'd be better to rollback the change and use Id instead of ID except for function-scoped variables.

@hallazzang hallazzang added the enhancement New feature or request label Jun 14, 2021
@hallazzang hallazzang self-assigned this Jun 14, 2021
@hallazzang
Copy link
Contributor Author

While this is an insignificant issue and those constant/variables are used internally, we're not gonna revert changes made in #376.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant