-
Notifications
You must be signed in to change notification settings - Fork 177
feat(deps): replace simple-tqdm with indicatif 0.18 to avoid unmaintained number_prefix #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bump indicatif instead. They have migrated to unit-prefix: https://github.com/console-rs/indicatif/blob/2f2b2ccbd3695e0a3cdbfed42c0d60190f732bbc/Cargo.toml#L18
@SuperFluffy yeah, the problem is that |
We should absolutely migrate. Looking at simple-tqdm, it was never maintained in the first place. IMO we should either do it now or close this PR. We shouldn't even start silencing nags like this one if there is a clear fix (lest we forget to actually followup). |
8231f7f to
556f9d4
Compare
makes sense, done in this PR ptal |
SuperFluffy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - we got cloudflare issues?
9f697b7 to
7dd763c
Compare
…ined number_prefix
Co-authored-by: Arsenii Kulikov <klkvrr@gmail.com>
59120b5 to
a969d8d
Compare
|
This has one confusing commit message now. :-D |
hmm this is weird i changed the PR title and amended the commit message... |
It's because you added the PR to the merge queue before your changes. The only "sync point" between PR title/body and commit title/body is when you enable auto-merge - that's the moment it takes the PR title/body and suggests it for your commit. It happened to me as well before. :-) |
TIL, very good to know thx! |
fixes errors like this one in https://github.com/tempoxyz/tempo/actions/runs/19462129274/job/55688586205?pr=948: