Skip to content

Conversation

@chaptersix
Copy link
Contributor

@chaptersix chaptersix commented Dec 15, 2025

What changed?

  • updates goreleaser to v2
  • add GHA for build admin-tools and server images within this repo. docker-builds will only be used for building pre 1.30 images
  • added GHA to promote docker builds from temporaliotest to temproalio docker image repos
  • trivy security scanning gates for image promotion (pulled rom docker-builds repo). The gate can be overridden

Why?

  • we decided to move away from building images in docker-builds. The complexity is not needed
  • updates goreleaser to v2 because the v1 definitions might be no longer supported at some point and this is a good time to do it
  • I used go scripts for the more complex flows instead of js or bash so we don't introduce another language contributors need to be familiar with. IMO the js or bash I did use it simple enough to understand.

How did you test it?

It passes in CI.

Potential risks

  • these build pipelines are only compatible with the new docker images.
  • merging this PR may break our nightly tests. Will double check before merging
  • flows that are not triggered by opening a PR are untested and therefore not completely validated

@chaptersix
Copy link
Contributor Author

@chaptersix chaptersix marked this pull request as ready for review December 15, 2025 20:13
@chaptersix chaptersix requested review from a team as code owners December 15, 2025 20:13
@chaptersix
Copy link
Contributor Author

Copy link
Contributor

@gow gow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See some comments below.

@chaptersix chaptersix enabled auto-merge (squash) December 18, 2025 18:25
@chaptersix chaptersix merged commit 8563567 into temporalio:main Dec 18, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants