Add Docker Images #8671
Add Docker Images #8671
Conversation
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
I skimmed this and added some comments.
Co-authored-by: Roey Berman <roey@temporal.io>
Co-authored-by: Kent Gruber <kent.gruber@temporal.io>
|
The makefile and build scripts will be removed In a future PR. Just here for demo/testing. The Alpine Image is an argument so we can trigger builds via workflows without committing to given branch. It should make re-building images easier |
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
I had a hard stop and didn't finish the review. Will continue tomorrow.
bergundy
left a comment
bergundy
left a comment
There was a problem hiding this comment.
I would really like us not to duplicate docker-builds and keep the mess that is that repo in that repo. Can we start fresh in the server repo without carrying over all of the legacy?
…e removed in favor of gha in another pr
Co-authored-by: Roey Berman <roey@temporal.io>
…ilding. next pr will have gha
removed in this PR |
What changed?
This PR add the new docker images with minimized dependencies. They are based on images from the
temporalio/docker-buildsrepository. These images will be used to build from version 1.30.0 and later.This PR focuses on the Dockerfiles and local build tooling. Future PRs will add GitHub Actions for automated builds.
Changes Made
Why?
The existing build process is more complex than it has to be and existing images have dependencies that are not necessary.
How did you test it?
Potential risks
Some users might depend on some of the dependencies we've included in our images until now. Or there some special case that we haven't taken into account.