Skip to content

Fix flaky test on QueryBeforeStart #12488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timl3136 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix flaky test on QueryBeforeStart #12488

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9edec03
Fix poll cancellation for unloaded root partition and flaky test on Q…
timl3136 Oct 9, 2026
0ac6b83
Merge branch 'main' into fix/TestQueryWorkflowSuite/TestQueryWorkflow…
timl3136 Oct 9, 2026
2b7033e
Merge branch 'main' into fix/TestQueryWorkflowSuite/TestQueryWorkflow…
timl3136 Oct 9, 2026
acc44d8
revert the matching engine change since it's not actually correct
timl3136 Oct 9, 2026
ba21302
Merge branch 'main' into fix/TestQueryWorkflowSuite/TestQueryWorkflow…
timl3136 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/query_workflow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,8 +437,8 @@ func (s *QueryWorkflowSuite) TestQueryWorkflow_QueryWhileBackoff() {

func (s *QueryWorkflowSuite) TestQueryWorkflow_QueryBeforeStart() {
env := testcore.NewEnv(s.T())
// stop the worker, so the workflow won't be started before query
env.SdkWorker().Stop()
// Don't call env.SdkWorker() (it lazily starts a worker), so no worker polls this task queue
// until queryWorker starts below and the query arrives before the first workflow task runs.

workflowFn := func(ctx workflow.Context) (string, error) {
status := "initialized"
Expand Down Expand Up @@ -488,6 +488,9 @@ func (s *QueryWorkflowSuite) TestQueryWorkflow_QueryBeforeStart() {
queryWorker.RegisterWorkflow(workflowFn)
err = queryWorker.Start()
s.NoError(err)
// Unlike env.SdkWorker(), this worker isn't stopped by the env's cleanup; stop it so its
// pollers don't outlive the test.
defer queryWorker.Stop()

// wait query
wg.Wait()
Expand Down
Loading