Repository navigation
Conversation
…_QueryBeforeStart
…_QueryBeforeStart
dnr
reviewed
Oct 9, 2026
Comment on lines
+1327
to
+1328
| numPartitions = max(1, e.config.NumTaskqueueReadPartitions( | ||
| nsName.String(), rootPartition.TaskQueue().Name(), request.GetTaskQueueType())) |
Contributor
There was a problem hiding this comment.
this isn't right once we turn on dynamic partitioning. you need to get the value from userdatamanager.partitionscale as above. which means the root partition needs to be loaded. but it's silly to load it just for this... is there any other way to solve this problem?
Contributor
Author
There was a problem hiding this comment.
Thanks, I will revert the change on matching.
…_QueryBeforeStart
timl3136
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
TestQueryWorkflow_QueryBeforeStart
no longer starts and immediately stopsenv.SdkWorker(), and it now stopsqueryWorker` for better gc.Why?
Fix flaky test described in #12486
How did you test it?