Skip to content

Feature-select OTLP exporter TLS backend#1333

Merged
Sushisource merged 2 commits into
temporalio:mainfrom
seanarnold:feat/otlp-tls-backend-selectable
Jun 16, 2026
Merged

Feature-select OTLP exporter TLS backend#1333
Sushisource merged 2 commits into
temporalio:mainfrom
seanarnold:feat/otlp-tls-backend-selectable

Conversation

@seanarnold

Copy link
Copy Markdown
Contributor

What was changed

PR #1274 made the TLS crypto backend
feature-selectable (tls-ring / tls-aws-lc) for the gRPC service client. This extends
that to the OTLP metric exporter. Previously opentelemetry-otlp hardcoded tls-roots +
reqwest-rustls, which always pulled in ring. Those are removed and replaced with
feature-gated wiring (tls-ring keeps today's behavior; tls-aws-lc routes the exporter
through aws-lc-rs), using opentelemetry-otlp 0.31.1's own tls-ring/tls-aws-lc
features.

Why?

#1274 covered the gRPC path, but the OTLP exporter still hardcoded ring, so a
ring-free, aws-lc-rs-only build (required for FIPS-capable deployments) wasn't
possible. Building with --no-default-features --features tls-aws-lc,otel now yields a
dependency tree free of ring.

Checklist

  1. Closes (no issue)

  2. How was this tested:

    • cargo tree -i ring across all targets: empty under tls-aws-lc, still present
      under the default tls-ring (no change to default builds).
    • cargo check/clippy clean for common (both backends) and sdk-core (default
      and aws-lc feature sets).
  3. Any docs updates needed?

    CHANGELOG.md updated.

@seanarnold
seanarnold requested a review from a team as a code owner June 16, 2026 02:36
@CLAassistant

CLAassistant commented Jun 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@seanarnold

Copy link
Copy Markdown
Contributor Author

@Sushisource Are you able to take a look at this one please? 🙇

@Sushisource Sushisource left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Sushisource
Sushisource merged commit 1982729 into temporalio:main Jun 16, 2026
22 of 23 checks passed
@seanarnold

Copy link
Copy Markdown
Contributor Author

Thanks @Sushisource. Do you think you could cut a new release, since there's quite a few changes since the last one v0.4.0...main

We're looking to use https://github.com/temporalio/sdk-ruby/ in a FIPS environment so would appreciate a release so we can follow up with a PR against that gem.

@Sushisource

Copy link
Copy Markdown
Member

@chris-olszewski Can comment on making a release. I think there's a few things he wants to get in first but I doubt it'll be long.

@chris-olszewski

Copy link
Copy Markdown
Member

@seanarnold Are you waiting for this to make it into the Ruby SDK? In the Ruby SDK we depend on the Rust core via a Git submodule so we don't need a tagged release of the Rust crates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants