Feature-select OTLP exporter TLS backend#1333
Merged
Sushisource merged 2 commits intoJun 16, 2026
Merged
Conversation
Contributor
Author
|
@Sushisource Are you able to take a look at this one please? 🙇 |
Contributor
Author
|
Thanks @Sushisource. Do you think you could cut a new release, since there's quite a few changes since the last one v0.4.0...main We're looking to use https://github.com/temporalio/sdk-ruby/ in a FIPS environment so would appreciate a release so we can follow up with a PR against that gem. |
Member
|
@chris-olszewski Can comment on making a release. I think there's a few things he wants to get in first but I doubt it'll be long. |
Member
|
@seanarnold Are you waiting for this to make it into the Ruby SDK? In the Ruby SDK we depend on the Rust core via a Git submodule so we don't need a tagged release of the Rust crates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
PR #1274 made the TLS crypto backend
feature-selectable (
tls-ring/tls-aws-lc) for the gRPC service client. This extendsthat to the OTLP metric exporter. Previously
opentelemetry-otlphardcodedtls-roots+reqwest-rustls, which always pulled inring. Those are removed and replaced withfeature-gated wiring (
tls-ringkeeps today's behavior;tls-aws-lcroutes the exporterthrough
aws-lc-rs), usingopentelemetry-otlp0.31.1's owntls-ring/tls-aws-lcfeatures.
Why?
#1274 covered the gRPC path, but the OTLP exporter still hardcoded
ring, so aring-free,aws-lc-rs-only build (required for FIPS-capable deployments) wasn'tpossible. Building with
--no-default-features --features tls-aws-lc,otelnow yields adependency tree free of
ring.Checklist
Closes (no issue)
How was this tested:
cargo tree -i ringacross all targets: empty undertls-aws-lc, still presentunder the default
tls-ring(no change to default builds).cargo check/clippyclean forcommon(both backends) andsdk-core(defaultand aws-lc feature sets).
Any docs updates needed?
CHANGELOG.md updated.