Make TLS backend feature-selectable in sdk-core and client#1274
Merged
Conversation
The hard-coded `tonic = { features = ["tls-ring", ...] }` in sdk-core and client forces ring on every consumer. Some users ban ring entirely (e.g. those standardised on aws-lc-rs for FIPS or supply-chain reasons) and cannot depend on temporalio-sdk because of this single line.
Add `tls-ring` and `tls-aws-lc` as crate features in both crates. `tls-ring`
remains the default so upstream behaviour is unchanged. Downstream users
can opt out:
```toml
[dependencies]
temporalio-sdk-core = {
version = "0.4",
default-features = false,
features = ["envconfig", "prometheus", "tls-aws-lc"],
}
```
|
|
Sushisource
approved these changes
May 15, 2026
Sushisource
left a comment
Sushisource
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution!
Sushisource
enabled auto-merge (squash)
May 15, 2026 15:52
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hard-coded
tonic = { features = ["tls-ring", ...] }in sdk-core and client forces ring on every consumer. Some users ban ring entirely (e.g. those standardised on aws-lc-rs for FIPS or supply-chain reasons) and cannot depend on temporalio-sdk because of this single line.Add
tls-ringandtls-aws-lcas crate features in both crates.tls-ringremains the default so upstream behaviour is unchanged. Downstream users can opt out:What was changed
Why?
Checklist
Closes
How was this tested: