Skip to content

Enforce minimum DNS resolution interval #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sushisource merged 2 commits into from
May 14, 2026
Merged

Enforce minimum DNS resolution interval #1272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b326c4
Enforce minimum DNS resolution interval
brucearctor May 14, 2026
075e6da
Merge branch 'main' into fix/dns-min-resolution-interval
Sushisource May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions crates/client/src/dns.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ use tokio::sync::mpsc;
use tonic::transport::{Channel, Endpoint, channel::Change};
use url::Url;

const MIN_DNS_RESOLUTION_INTERVAL: Duration = Duration::from_secs(1);

/// Validates DNS load balancing configuration and returns the options if DNS LB should be used.
///
/// Returns `Err` if `dns_load_balancing` is set alongside `service_override` or
Expand Down Expand Up @@ -38,6 +40,14 @@ pub(crate) fn validate_and_get_dns_lb(
.host()
.ok_or_else(|| ClientConnectError::InvalidConfig("target URL has no host".to_owned()))?;

if dns_opts.resolution_interval < MIN_DNS_RESOLUTION_INTERVAL {
return Err(ClientConnectError::InvalidConfig(format!(
"dns_load_balancing.resolution_interval must be at least \
{MIN_DNS_RESOLUTION_INTERVAL:?}, got {:?}",
dns_opts.resolution_interval
)));
}

match host {
url::Host::Domain("localhost") => Ok(None),
url::Host::Domain(_) => Ok(Some(dns_opts)),
Expand Down Expand Up @@ -303,4 +313,26 @@ mod tests {
let addr: SocketAddr = "[::1]:7233".parse().unwrap();
assert_eq!(endpoint_uri(addr, "https"), "https://[::1]:7233");
}

#[test]
fn zero_resolution_interval_is_error() {
let opts = ConnectionOptions::new(Url::parse("http://temporal.example.com:7233").unwrap())
.dns_load_balancing(Some(DnsLoadBalancingOptions {
resolution_interval: Duration::ZERO,
..Default::default()
}))
.build();
assert!(validate_and_get_dns_lb(&opts).is_err());
}

#[test]
fn sub_minimum_resolution_interval_is_error() {
let opts = ConnectionOptions::new(Url::parse("http://temporal.example.com:7233").unwrap())
.dns_load_balancing(Some(DnsLoadBalancingOptions {
resolution_interval: Duration::from_millis(500),
..Default::default()
}))
.build();
assert!(validate_and_get_dns_lb(&opts).is_err());
}
}
Loading