Enforce minimum DNS resolution interval#1272
Merged
Sushisource merged 2 commits intoMay 14, 2026
Merged
Conversation
Reject dns_load_balancing.resolution_interval values below 1 second in validate_and_get_dns_lb() to prevent a tight re-resolution loop when set to Duration::ZERO. Fixes temporalio#1266
Sushisource
enabled auto-merge (squash)
May 14, 2026 20:42
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds validation to reject
dns_load_balancing.resolution_intervalvalues below 1 second.Why
Without a floor, setting
resolution_intervaltoDuration::ZEROcausesspawn_dns_reresolution()to run a tight loop —tokio::time::sleep(Duration::ZERO)yields immediately, hammering DNS with unrestricted re-resolution.How
MIN_DNS_RESOLUTION_INTERVAL(1s) constant and a check invalidate_and_get_dns_lb(), returningClientConnectError::InvalidConfigfor sub-minimum values. This follows the existing pattern for conflicting option validation in the same function.Duration::ZERO, one for a sub-minimum value (500ms).Fixes #1266