Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyproject.toml: Removed protoc-wheel dependency #684

Merged
merged 2 commits into from
Nov 13, 2024
Merged

pyproject.toml: Removed protoc-wheel dependency #684

merged 2 commits into from
Nov 13, 2024

Conversation

jpds
Copy link
Contributor

@jpds jpds commented Nov 6, 2024

What was changed

Removed protoc-wheel-0 dependency from pyproject.toml. I think this was missing from #547.

I needed to patch this out in the nixpkgs package to make the build succeed: 353720

@jpds jpds requested a review from a team as a code owner November 6, 2024 14:40
@CLAassistant
Copy link

CLAassistant commented Nov 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jpds jpds force-pushed the remove-protoc-wheel-requirement branch from 17afd7e to c641686 Compare November 6, 2024 14:41
@jpds jpds force-pushed the remove-protoc-wheel-requirement branch from c641686 to f41ec84 Compare November 6, 2024 14:42
@jpds jpds changed the title pyproject.yoml: Removed protoc-wheel dependency pyproject.toml: Removed protoc-wheel dependency Nov 6, 2024
cretz
cretz approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes I think we missed this. Will confirm CI passes, merge main back into your branch, and if CI passes again, will merge.

@cretz cretz merged commit 001ce8b into temporalio:main Nov 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpds @CLAassistant @cretz