Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proto wheel and other minor fixes #547

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Remove proto wheel and other minor fixes #547

merged 2 commits into from
Jun 10, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Jun 10, 2024 •
edited
Loading

What was changed

  • Remove protoc-wheel-0 dev dependency and add protoc to CI and build instructions
  • Fix minor issues with isort and Pydantic

Checklist

  1. Closes [Bug] protoc-wheel-0 dev dependency causing issues when building on musl-based distros like Alpine #412

@cretz cretz force-pushed the remove-proto-wheel branch 2 times, most recently from 6ecadc0 to a622f0d Compare June 10, 2024 16:02
@cretz cretz changed the title Remove proto wheel Remove proto wheel and other minor fixes Jun 10, 2024
@cretz cretz force-pushed the remove-proto-wheel branch 6 times, most recently from 17eb4e0 to 1003d28 Compare June 10, 2024 17:20
@cretz cretz marked this pull request as ready for review June 10, 2024 17:36
@cretz cretz requested a review from a team as a code owner June 10, 2024 17:36
@cretz cretz merged commit 927415a into temporalio:main Jun 10, 2024
12 checks passed
@cretz cretz deleted the remove-proto-wheel branch June 10, 2024 18:13
@mjameswh mjameswh mentioned this pull request Jun 13, 2024
Merged
@jpds jpds mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] protoc-wheel-0 dev dependency causing issues when building on musl-based distros like Alpine
2 participants
@cretz @Sushisource