Skip to content

Add macOS ARM runner #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/build-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,26 @@ jobs:
include:
- os: ubuntu-latest
package-suffix: linux-amd64
- os: macos-latest
package-suffix: macos-amd64
- os: windows-latest
package-suffix: windows-amd64
- os: ubuntu-arm
package-suffix: linux-aarch64
# Need the 8 CPU version that has 12GB of RAM, the 4 CPU version
# only has 6 GB.
runsOn: buildjet-8vcpu-ubuntu-2204-arm
- os: macos-intel
package-suffix: macos-amd64
runsOn: macos-12
- os: macos-arm
package-suffix: macos-aarch64
runsOn: macos-14
- os: windows-latest
package-suffix: windows-amd64
runs-on: ${{ matrix.runsOn || matrix.os }}
steps:
- uses: actions/checkout@v2
with:
submodules: recursive
# actions/setup-python doesn't yet support ARM
- if: ${{ !endsWith(matrix.os, '-arm') }}
# actions/setup-python doesn't yet support Linux ARM
- if: ${{ matrix.os != 'ubuntu-arm' }}
uses: actions/setup-python@v4
with:
python-version: "3.12"
Expand Down
17 changes: 14 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
fail-fast: true
matrix:
python: ["3.8", "3.12"]
os: [ubuntu-latest, macos-latest, windows-latest, ubuntu-arm]
os: [ubuntu-latest, ubuntu-arm, macos-intel, macos-arm, windows-latest]
include:
- os: ubuntu-latest
python: "3.12"
Expand All @@ -23,6 +23,17 @@ jobs:
protoCheckTarget: true
- os: ubuntu-arm
runsOn: buildjet-4vcpu-ubuntu-2204-arm
- os: macos-intel
runsOn: macos-12
- os: macos-arm
runsOn: macos-14
# macOS ARM 3.8 does not have an available Python build at
# https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json.
# See https://github.com/actions/setup-python/issues/808 and
# https://github.com/actions/python-versions/pull/259.
exclude:
- os: macos-arm
python: "3.8"
runs-on: ${{ matrix.runsOn || matrix.os }}
steps:
- uses: actions/checkout@v2
Expand All @@ -34,8 +45,8 @@ jobs:
- uses: Swatinem/rust-cache@v1
with:
working-directory: temporalio/bridge
# actions/setup-python doesn't yet support ARM
- if: ${{ !endsWith(matrix.os, '-arm') }}
# actions/setup-python doesn't yet support Linux ARM
- if: ${{ matrix.os != 'ubuntu-arm' }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python }}
Expand Down
Loading