Skip to content

Add macOS ARM runner #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2024
Merged

Add macOS ARM runner #506

merged 2 commits into from
Apr 12, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Apr 12, 2024 •
edited
Loading

What was changed

  • Add macOS ARM runner for CI builds
    • Had to remove 3.8 testing, see comment
  • Add macOS ARM runner for binary build
    • Had to work around some cibuildwheel strangeness, see comment
    • Confirmed that it works in draft form of this PR (it doesn't run on PR, only push)

Once reviewed/complete, I'll update the branch-restriction required checks to include it

Checklist

  1. Closes [Feature Request] Use macOS M1/ARM runners for all SDK CI #495

@cretz cretz force-pushed the macos-arm branch 6 times, most recently from 3b48161 to 156e7f3 Compare April 12, 2024 15:53
@cretz cretz marked this pull request as ready for review April 12, 2024 18:10
@cretz cretz requested a review from a team as a code owner April 12, 2024 18:10
@cretz cretz merged commit b45447e into temporalio:main Apr 12, 2024
@cretz cretz deleted the macos-arm branch April 12, 2024 19:47
@cretz cretz mentioned this pull request Apr 25, 2024
Merged
@cretz cretz mentioned this pull request May 23, 2024
Merged
@dandavison dandavison mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Use macOS M1/ARM runners for all SDK CI
2 participants
@cretz @Sushisource