Skip to content

Don't require timer presence when fired #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2022
Merged

Don't require timer presence when fired #169

merged 3 commits into from
Oct 28, 2022

Conversation

cretz
Copy link
Member

@cretz cretz commented Oct 27, 2022

What was changed

Stop requiring a timer to be present when fired

Why?

Timer can be removed from a signal that cancels it before the firing event of the same activation is reached

Checklist

  1. Closes [Bug] Do not require timer to be present when fire-timer received #167

@cretz cretz requested a review from a team October 27, 2022 15:18
@cretz
Copy link
Member Author

cretz commented Oct 27, 2022

(can't merge until #164 is merged)

@cretz cretz merged commit 657a13d into temporalio:main Oct 28, 2022
@cretz cretz deleted the timer-fix branch October 28, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergundy bergundy bergundy approved these changes

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Do not require timer to be present when fire-timer received
3 participants
@cretz @bergundy @Sushisource