Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gogo/protobuf with google/protobuf #359

Merged
merged 19 commits into from
Nov 22, 2023
Merged

Replace gogo/protobuf with google/protobuf #359

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
dd86df9
Add the ability to override the SDK repo when building
tdeebswihart Oct 20, 2023
4ab94a5
Bump my forks
tdeebswihart Oct 17, 2023
97f137b
Point the go harness at my forks
tdeebswihart Oct 20, 2023
6651747
Go mod tidy
tdeebswihart Oct 20, 2023
0187092
Rip out gogo
tdeebswihart Oct 25, 2023
c802322
Use temporalproto and our testify helpers
tdeebswihart Oct 25, 2023
9550d0e
Fix a feature and add caller log skipping.
tdeebswihart Oct 25, 2023
64e07ed
Add relevant replaces to feature-test go.mod
tdeebswihart Oct 25, 2023
6cbb2d1
Maybe this is right
tdeebswihart Oct 25, 2023
d67cf6a
Bump go version & use my go SDK fork
tdeebswihart Oct 26, 2023
9e0194b
Remove test helpers
tdeebswihart Oct 26, 2023
1a5b6b9
REALLY Use my sdk fork
tdeebswihart Oct 26, 2023
43ecff4
Use the new temporalproto JSON options
tdeebswihart Oct 30, 2023
02a61b0
Remove all references to my forks
tdeebswihart Nov 21, 2023
a56e678
Use the official SDK repo and go 1.20
tdeebswihart Nov 21, 2023
207b69d
Replace the SDK version for the built docker image as well
tdeebswihart Nov 21, 2023
0425027
Add go-repo-ref and specify it
tdeebswihart Nov 21, 2023
5c9f41d
Also add go-repo-ref to the PR target
tdeebswihart Nov 21, 2023
0d275db
Yes, its a repo ref
tdeebswihart Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use the new temporalproto JSON options
  • Loading branch information
@tdeebswihart
tdeebswihart committed Nov 21, 2023
commit 43ecff459e4bb6681181eb0aefe3682db5efd026
2 changes: 1 addition & 1 deletion features/data_converter/binary/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func CheckResult(ctx context.Context, runner *harness.Runner, run client.Workflo
}

expectedPayload := &common.Payload{}
decoder := temporalproto.NewJSONDecoder(file)
decoder := temporalproto.NewJSONDecoder(file, false)
if err := decoder.Decode(expectedPayload); err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion features/data_converter/empty/feature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func CheckResult(ctx context.Context, runner *harness.Runner, run client.Workflo
}

expectedPayload := &common.Payload{}
decoder := temporalproto.NewJSONDecoder(file)
decoder := temporalproto.NewJSONDecoder(file, false)
if err := decoder.Decode(expectedPayload); err != nil {
return err
}
Expand Down
8 changes: 4 additions & 4 deletions features/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@ module github.com/temporalio/features/features
go 1.20

replace (
go.temporal.io/api => github.com/tdeebswihart/temporal-api-go v0.0.0-20231024224906-a4867f8364cf
go.temporal.io/sdk => github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231025182128-a3f3a93f2f0e
go.temporal.io/api => github.com/tdeebswihart/temporal-api-go v0.0.0-20231030173112-e3f2b0b8d7b6
go.temporal.io/sdk => github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231030171429-734eb22c9c89
)

require (
github.com/google/uuid v1.3.0
github.com/google/uuid v1.3.1
github.com/temporalio/features/harness/go v1.0.0
github.com/uber-go/tally/v4 v4.1.1
go.temporal.io/api v1.24.0
go.temporal.io/sdk v1.25.0
go.temporal.io/sdk/contrib/tally v0.1.0
golang.org/x/mod v0.11.0
google.golang.org/grpc v1.58.3
google.golang.org/grpc v1.59.0
google.golang.org/protobuf v1.31.0
)

Expand Down
18 changes: 11 additions & 7 deletions features/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,8 +1026,9 @@ github.com/gogo/protobuf v1.3.2/go.mod h1:P1XiOD3dCwIKUDQYPy72D8LYyHL2YPYrpS2s69
github.com/golang/freetype v0.0.0-20170609003504-e2365dfdc4a0/go.mod h1:E/TSTwGwJL78qG/PmXZO1EjYhfJinVAhrmmHX6Z8B9k=
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=
github.com/golang/glog v1.0.0/go.mod h1:EWib/APOK0SL3dFbYqvxE3UYd8E6s1ouQ7iEp/0LWV4=
github.com/golang/glog v1.1.0 h1:/d3pCKDPWNnvIWe0vVUpNP32qc8U3PDVxySP/y360qE=
github.com/golang/glog v1.1.0/go.mod h1:pfYeQZ3JWZoXTV5sFc986z3HTpwQs9At6P4ImfuP3NQ=
github.com/golang/glog v1.1.2 h1:DVjP2PbBOzHyzA+dn3WhHIq4NdVu3Q+pvivFICf/7fo=
github.com/golang/glog v1.1.2/go.mod h1:zR+okUeTbrL6EL3xHUDxZuEtGv04p5shwip1+mL/rLQ=
github.com/golang/groupcache v0.0.0-20190702054246-869f871628b6/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
github.com/golang/groupcache v0.0.0-20191227052852-215e87163ea7/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
Expand Down Expand Up @@ -1111,8 +1112,9 @@ github.com/google/s2a-go v0.1.4/go.mod h1:Ej+mSEMGRnqRzjc7VtF+jdBwYG5fuJfiZ8ELkj
github.com/google/s2a-go v0.1.7/go.mod h1:50CgR4k1jNlWBu4UfS4AcfhVe1r6pdZPygJ3R8F0Qdw=
github.com/google/uuid v1.0.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/google/uuid v1.1.2/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/google/uuid v1.3.0 h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I=
github.com/google/uuid v1.3.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/google/uuid v1.3.1 h1:KjJaJ9iWZ3jOFZIf1Lqf4laDRCasjl0BCmnEGxkdLb4=
github.com/google/uuid v1.3.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/googleapis/enterprise-certificate-proxy v0.0.0-20220520183353-fd19c99a87aa/go.mod h1:17drOmN3MwGY7t0e+Ei9b45FFGA3fBs3x36SsCg1hq8=
github.com/googleapis/enterprise-certificate-proxy v0.1.0/go.mod h1:17drOmN3MwGY7t0e+Ei9b45FFGA3fBs3x36SsCg1hq8=
github.com/googleapis/enterprise-certificate-proxy v0.2.0/go.mod h1:8C0jb7/mgJe/9KK8Lm7X9ctZC2t60YyIpYEI16jx0Qg=
Expand Down Expand Up @@ -1268,10 +1270,10 @@ github.com/stretchr/testify v1.8.2/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o
github.com/stretchr/testify v1.8.3/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231016220718-646941139bf7 h1:wuR7T727UoUZS/qCA9LrOBoW/d86LmGwzonmbV7pZHg=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231016220718-646941139bf7/go.mod h1:pXH5EOzQW7C4Eh1l12A1JvW5Uo2LBIHQIx/K/8YoFaA=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231017162805-b4c4dbb2a35a h1:a2s3R/1U5YgtAy+vMHJm0vKO9EsI0bADNpHqHyTqJmE=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231017162805-b4c4dbb2a35a/go.mod h1:uB6E0lk9KuzGYbXaC92CIJsQaUm0nMQ2V+Bc67QA7Hc=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231030173112-e3f2b0b8d7b6 h1:3VU2ATcfOHdVbBuHRDRUG+8lxxfAVcQjF52PxKHyxEE=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231030173112-e3f2b0b8d7b6/go.mod h1:ZMitJTNmbXZkOJENNfv6wSysT4UenqGL918N5N6SH4I=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231030171429-734eb22c9c89 h1:mcLkjxxtUvmBFd4avFcYU3f6bWGyX6FTCsmgc2Shs7Y=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231030171429-734eb22c9c89/go.mod h1:q9T6ccrOVY3vzbGo/9mXRMf04GWFptZWakfVHdK68uk=
github.com/twmb/murmur3 v1.1.5/go.mod h1:Qq/R7NUyOfr65zD+6Q5IHKsJLwP7exErjN6lyyq3OSQ=
github.com/twmb/murmur3 v1.1.6 h1:mqrRot1BRxm+Yct+vavLMou2/iJt0tNVTTC0QoIjaZg=
github.com/twmb/murmur3 v1.1.6/go.mod h1:Qq/R7NUyOfr65zD+6Q5IHKsJLwP7exErjN6lyyq3OSQ=
Expand Down Expand Up @@ -1943,6 +1945,7 @@ google.golang.org/genproto v0.0.0-20230711160842-782d3b101e98/go.mod h1:S7mY02Oq
google.golang.org/genproto v0.0.0-20230726155614-23370e0ffb3e/go.mod h1:0ggbjUrZYpy1q+ANUS30SEoGZ53cdfwtbuG7Ptgy108=
google.golang.org/genproto v0.0.0-20230803162519-f966b187b2e5/go.mod h1:oH/ZOT02u4kWEp7oYBGYFFkCdKS/uYR9Z7+0/xuuFp8=
google.golang.org/genproto v0.0.0-20230821184602-ccc8af3d0e93/go.mod h1:yZTlhN0tQnXo3h00fuXNCxJdLdIdnVFVBaRJ5LWBbw4=
google.golang.org/genproto v0.0.0-20230822172742-b8732ec3820d/go.mod h1:yZTlhN0tQnXo3h00fuXNCxJdLdIdnVFVBaRJ5LWBbw4=
google.golang.org/genproto v0.0.0-20230913181813-007df8e322eb/go.mod h1:yZTlhN0tQnXo3h00fuXNCxJdLdIdnVFVBaRJ5LWBbw4=
google.golang.org/genproto v0.0.0-20230920204549-e6e6cdab5c13/go.mod h1:CCviP9RmpZ1mxVr8MUjCnSiY09IbAXZxhLE6EhHIdPU=
google.golang.org/genproto v0.0.0-20231002182017-d307bd883b97/go.mod h1:t1VqOqqvce95G3hIDCT5FeO3YUc6Q4Oe24L/+rNMxRk=
Expand Down Expand Up @@ -2030,8 +2033,9 @@ google.golang.org/grpc v1.56.2/go.mod h1:I9bI3vqKfayGqPUAwGdOSu7kt6oIJLixfffKrpX
google.golang.org/grpc v1.57.0/go.mod h1:Sd+9RMTACXwmub0zcNY2c4arhtrbBYD1AUHI/dt16Mo=
google.golang.org/grpc v1.58.0/go.mod h1:tgX3ZQDlNJGU96V6yHh1T/JeoBQ2TXdr43YbYSsCJk0=
google.golang.org/grpc v1.58.2/go.mod h1:tgX3ZQDlNJGU96V6yHh1T/JeoBQ2TXdr43YbYSsCJk0=
google.golang.org/grpc v1.58.3 h1:BjnpXut1btbtgN/6sp+brB2Kbm2LjNXnidYujAVbSoQ=
google.golang.org/grpc v1.58.3/go.mod h1:tgX3ZQDlNJGU96V6yHh1T/JeoBQ2TXdr43YbYSsCJk0=
google.golang.org/grpc v1.59.0 h1:Z5Iec2pjwb+LEOqzpB2MR12/eKFhDPhuqW91O+4bwUk=
google.golang.org/grpc v1.59.0/go.mod h1:aUPDwccQo6OTjy7Hct4AfBPD1GptF4fyUjIkQ9YtF98=
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.1.0/go.mod h1:6Kw0yEErY5E/yWrBtf03jp27GLLJujG4z/JK95pnjjw=
google.golang.org/protobuf v0.0.0-20200109180630-ec00e32a8dfd/go.mod h1:DFci5gLYBciE7Vtevhsrf46CRTquxDuWsQurQQe4oz8=
google.golang.org/protobuf v0.0.0-20200221191635-4d8936d0db64/go.mod h1:kwYJMbMJ01Woi6D6+Kah6886xMZcty6N08ah7+eCXa0=
Expand Down
5 changes: 2 additions & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ module github.com/temporalio/features
go 1.18

replace (
go.temporal.io/api => github.com/tdeebswihart/temporal-api-go v0.0.0-20231016220718-646941139bf7
go.temporal.io/sdk => github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231017162805-b4c4dbb2a35a
go.temporal.io/api => github.com/tdeebswihart/temporal-api-go v0.0.0-20231030173112-e3f2b0b8d7b6
go.temporal.io/sdk => github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231030171429-734eb22c9c89
)

require (
Expand All @@ -25,7 +25,6 @@ require (
github.com/gogo/protobuf v1.3.2 // indirect
github.com/golang/mock v1.6.0 // indirect
github.com/golang/protobuf v1.5.3 // indirect
github.com/google/go-cmp v0.5.9 // indirect
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 // indirect
github.com/grpc-ecosystem/grpc-gateway/v2 v2.18.0 // indirect
github.com/iancoleman/strcase v0.3.0 // indirect
Expand Down
10 changes: 6 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,6 +1031,7 @@ github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfU
github.com/golang/glog v1.0.0/go.mod h1:EWib/APOK0SL3dFbYqvxE3UYd8E6s1ouQ7iEp/0LWV4=
github.com/golang/glog v1.1.0/go.mod h1:pfYeQZ3JWZoXTV5sFc986z3HTpwQs9At6P4ImfuP3NQ=
github.com/golang/glog v1.1.2 h1:DVjP2PbBOzHyzA+dn3WhHIq4NdVu3Q+pvivFICf/7fo=
github.com/golang/glog v1.1.2/go.mod h1:zR+okUeTbrL6EL3xHUDxZuEtGv04p5shwip1+mL/rLQ=
github.com/golang/groupcache v0.0.0-20190702054246-869f871628b6/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
github.com/golang/groupcache v0.0.0-20191227052852-215e87163ea7/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
Expand Down Expand Up @@ -1279,10 +1280,10 @@ github.com/stretchr/testify v1.8.2/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o
github.com/stretchr/testify v1.8.3/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231016220718-646941139bf7 h1:wuR7T727UoUZS/qCA9LrOBoW/d86LmGwzonmbV7pZHg=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231016220718-646941139bf7/go.mod h1:pXH5EOzQW7C4Eh1l12A1JvW5Uo2LBIHQIx/K/8YoFaA=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231017162805-b4c4dbb2a35a h1:a2s3R/1U5YgtAy+vMHJm0vKO9EsI0bADNpHqHyTqJmE=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231017162805-b4c4dbb2a35a/go.mod h1:uB6E0lk9KuzGYbXaC92CIJsQaUm0nMQ2V+Bc67QA7Hc=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231030173112-e3f2b0b8d7b6 h1:3VU2ATcfOHdVbBuHRDRUG+8lxxfAVcQjF52PxKHyxEE=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231030173112-e3f2b0b8d7b6/go.mod h1:ZMitJTNmbXZkOJENNfv6wSysT4UenqGL918N5N6SH4I=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231030171429-734eb22c9c89 h1:mcLkjxxtUvmBFd4avFcYU3f6bWGyX6FTCsmgc2Shs7Y=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231030171429-734eb22c9c89/go.mod h1:q9T6ccrOVY3vzbGo/9mXRMf04GWFptZWakfVHdK68uk=
github.com/twmb/murmur3 v1.1.5/go.mod h1:Qq/R7NUyOfr65zD+6Q5IHKsJLwP7exErjN6lyyq3OSQ=
github.com/twmb/murmur3 v1.1.8 h1:8Yt9taO/WN3l08xErzjeschgZU2QSrwm1kclYq+0aRg=
github.com/twmb/murmur3 v1.1.8/go.mod h1:Qq/R7NUyOfr65zD+6Q5IHKsJLwP7exErjN6lyyq3OSQ=
Expand Down Expand Up @@ -1965,6 +1966,7 @@ google.golang.org/genproto v0.0.0-20230711160842-782d3b101e98/go.mod h1:S7mY02Oq
google.golang.org/genproto v0.0.0-20230726155614-23370e0ffb3e/go.mod h1:0ggbjUrZYpy1q+ANUS30SEoGZ53cdfwtbuG7Ptgy108=
google.golang.org/genproto v0.0.0-20230803162519-f966b187b2e5/go.mod h1:oH/ZOT02u4kWEp7oYBGYFFkCdKS/uYR9Z7+0/xuuFp8=
google.golang.org/genproto v0.0.0-20230821184602-ccc8af3d0e93/go.mod h1:yZTlhN0tQnXo3h00fuXNCxJdLdIdnVFVBaRJ5LWBbw4=
google.golang.org/genproto v0.0.0-20230822172742-b8732ec3820d/go.mod h1:yZTlhN0tQnXo3h00fuXNCxJdLdIdnVFVBaRJ5LWBbw4=
google.golang.org/genproto v0.0.0-20230913181813-007df8e322eb/go.mod h1:yZTlhN0tQnXo3h00fuXNCxJdLdIdnVFVBaRJ5LWBbw4=
google.golang.org/genproto v0.0.0-20230920204549-e6e6cdab5c13/go.mod h1:CCviP9RmpZ1mxVr8MUjCnSiY09IbAXZxhLE6EhHIdPU=
google.golang.org/genproto v0.0.0-20231002182017-d307bd883b97/go.mod h1:t1VqOqqvce95G3hIDCT5FeO3YUc6Q4Oe24L/+rNMxRk=
Expand Down
5 changes: 2 additions & 3 deletions harness/go/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@ module github.com/temporalio/features/harness/go
go 1.20

replace (
go.temporal.io/api => github.com/tdeebswihart/temporal-api-go v0.0.0-20231024224906-a4867f8364cf
go.temporal.io/sdk => github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231025182128-a3f3a93f2f0e
go.temporal.io/api => github.com/tdeebswihart/temporal-api-go v0.0.0-20231030173112-e3f2b0b8d7b6
go.temporal.io/sdk => github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231030171429-734eb22c9c89
)

require (
github.com/google/go-cmp v0.5.9
github.com/google/uuid v1.3.1
github.com/stretchr/testify v1.8.4
github.com/urfave/cli/v2 v2.3.0
Expand Down
9 changes: 4 additions & 5 deletions harness/go/go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ github.com/golang/protobuf v1.5.3/go.mod h1:XVQd3VNwM+JqD3oG2Ue2ip4fOMUkwXdXDdiu
github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5aqRK0M=
github.com/google/go-cmp v0.5.5/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38=
github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/google/uuid v1.0.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/google/uuid v1.3.1 h1:KjJaJ9iWZ3jOFZIf1Lqf4laDRCasjl0BCmnEGxkdLb4=
github.com/google/uuid v1.3.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
Expand Down Expand Up @@ -84,10 +83,10 @@ github.com/stretchr/testify v1.7.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO+kdMU+MU=
github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231024224906-a4867f8364cf h1:WlXd+zhSaEGydariuk2pTKpE7epYGJqQBANwP7UAebE=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231024224906-a4867f8364cf/go.mod h1:ZMitJTNmbXZkOJENNfv6wSysT4UenqGL918N5N6SH4I=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231025182128-a3f3a93f2f0e h1:4hENCBhP/X9THutfuZ8HwXwcJm4bLCq6EkrYW50G5Sk=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231025182128-a3f3a93f2f0e/go.mod h1:2ZJiRYA7wb4YkLQM9Pg5kOjal3DE6KE6r6eyRkYGppU=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231030173112-e3f2b0b8d7b6 h1:3VU2ATcfOHdVbBuHRDRUG+8lxxfAVcQjF52PxKHyxEE=
github.com/tdeebswihart/temporal-api-go v0.0.0-20231030173112-e3f2b0b8d7b6/go.mod h1:ZMitJTNmbXZkOJENNfv6wSysT4UenqGL918N5N6SH4I=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231030171429-734eb22c9c89 h1:mcLkjxxtUvmBFd4avFcYU3f6bWGyX6FTCsmgc2Shs7Y=
github.com/tdeebswihart/temporal-sdk-go v0.0.0-20231030171429-734eb22c9c89/go.mod h1:q9T6ccrOVY3vzbGo/9mXRMf04GWFptZWakfVHdK68uk=
github.com/urfave/cli/v2 v2.3.0 h1:qph92Y649prgesehzOrQjdWyxFOp/QVM+6imKHad91M=
github.com/urfave/cli/v2 v2.3.0/go.mod h1:LJmUH05zAU44vOAcrfzZQKsZbVcdbOG8rtL3/XcUArI=
github.com/yuin/goldmark v1.1.27/go.mod h1:3hX8gzYuyVAZsxl0MRgGTJEmQBFcNTphYh9decYSb74=
Expand Down
5 changes: 4 additions & 1 deletion harness/go/history/history.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,12 @@ func (h *Histories) UnmarshalJSON(b []byte) error {
return err
}
hists := make([]*history.History, len(halfUnmarshaled))
opts := temporalproto.JSONUnmarshaller{
DiscardUnknown: true,
}
for i, histJSON := range halfUnmarshaled {
var hist history.History
if err := temporalproto.UnmarshalJSON(histJSON, &hist); err != nil {
if err := opts.Unmarshal(histJSON, &hist); err != nil {
return err
}
hists[i] = &hist
Expand Down