Replace gogo/protobuf with google/protobuf #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Oct 26, 2023
tdeebswihart
force-pushed
the
nomo-gogo
branch
from
2d73484 to
7cb11a9
Compare
| @@ -98,7 +100,7 @@ func (f *Fetcher) GetExecutions(ctx context.Context) ([]*workflow.WorkflowExecut | |||
| Namespace: f.Namespace, | |||
| MaximumPageSize: 1000, | |||
| NextPageToken: nextPageToken, | |||
| StartTimeFilter: &filter.StartTimeFilter{EarliestTime: &earliest}, | |||
| StartTimeFilter: &filter.StartTimeFilter{EarliestTime: timestamppb.New(earliest)}, | |||
There was a problem hiding this comment.
(More a general gogoproto migration question) Just to confirm this would be a visible change to the API for users correct? and we are OK with that?
There was a problem hiding this comment.
To the wire format or to the Go API? The wire format will remain unchanged
There was a problem hiding this comment.
I meant an Go API change
There was a problem hiding this comment.
Ah, yes. It will be and there's no way around it
Quinn-With-Two-Ns
approved these changes
Nov 17, 2023
tdeebswihart
force-pushed
the
nomo-gogo
branch
2 times, most recently
from
83eabe6 to
9cdfbe1
Compare
And convert the repo to use my forks
tdeebswihart
force-pushed
the
nomo-gogo
branch
from
9cdfbe1 to
02a61b0
Compare
Quinn-With-Two-Ns
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
gogo/protobuf has been replaced with Google's official go compiler.
Why?
gogo/protobuf has been deprecated for some time and the community is moving on, building new tools (like vtproto) atop google's v2 compiler.
How did you test it?
This branch is actively used by my SDK and server PRs so you can see it in use there
Potential risks
None I can think of.
Breaking changes for developers
*time.Timein proto structs will now be timestamppb.Timestamp*time.Durationwill now be durationpb.Durationgo vetwill scream at you about this. If you need a copy, useproto.Clone.reflect.DeepEqualor anything that uses it. This includestestifyandmockequality testers!protorequireroprotoassertpackages instead. I've implemented proto-compatible assertions there for all cases I've encounteredreflect.DeepEqualfor any reason you can usego.temporal.io/api/temporalproto.DeepEqualinsteadRelease Plan
Our goal is to release our API, Go API, Go SDK, and Server all at once, then update our UI (and ui-server), CLI, and HTTP API in a second pass. Until the second pass happens no changes to our JSON formatting will be apparent to users.