Skip to content

Conversation

@picatz
Copy link
Contributor

@picatz picatz commented Nov 4, 2025

Summary

  • .github/workflows/trigger-publish.yml: Set the GitHub App token step to include owner temporalio and added repositories list for cli and docker-builds so the generated token retains access to both repos.
  • .github/workflows/trigger-docs.yml: Upgraded the GitHub App token step to actions/create-github-app-token@v2 and switched repositories input to a multiline list (documentation) with an explanatory comment while keeping the owner scoped to the repository owner.

Previous summary:

Summary

  • .github/workflows/trigger-publish.yml: Replaced tibdex/github-app-token with actions/create-github-app-token@v2 and converted inputs to the new action’s kebab-case names so the workflow continues generating the app token securely.

This change was made by an automated process to ensure all GitHub Actions workflows use the official GitHub application token action.

Assisted-by: GPT-5 Codex via Camper
@picatz picatz requested review from a team as code owners November 4, 2025 16:47
@semgrep-managed-scans
Copy link

Semgrep found 1 missing-explicit-permissions finding:

No explicit GITHUB_TOKEN permissions found at the workflow or job level. Add a permissions: block at the workflow root (applies to all jobs) or per job with least privilege (e.g., contents: read and only specific writes like pull-requests: write if needed).

@picatz
Copy link
Contributor Author

picatz commented Nov 4, 2025

☝️ Should be resolved with #869 (comment)

This refresh aligns owner/repositories inputs with actions/create-github-app-token@v2 defaults while preserving necessary repository access.

Assisted-by: GPT-5 Codex via Camper
@semgrep-managed-scans

This comment was marked as duplicate.

Copy link
Contributor

@spkane31 spkane31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@picatz
Copy link
Contributor Author

picatz commented Nov 12, 2025

Thank you, @spkane31 and @chris-olszewski! Looks like I don't have the ability to merge this PR, can one of you?

@chris-olszewski chris-olszewski merged commit d1bdd23 into main Nov 12, 2025
8 checks passed
@chris-olszewski chris-olszewski deleted the security-campaign/gha-deprecated-app-token-action branch November 12, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants