Skip to content

Commit d1bdd23

Browse files
authored
VLN-442: Use first-party action for GitHub app tokens (#872)
## Summary - `.github/workflows/trigger-publish.yml`: Set the GitHub App token step to include owner temporalio and added repositories list for cli and docker-builds so the generated token retains access to both repos. - `.github/workflows/trigger-docs.yml`: Upgraded the GitHub App token step to actions/create-github-app-token@v2 and switched repositories input to a multiline list (documentation) with an explanatory comment while keeping the owner scoped to the repository owner. --- Previous summary: ## Summary - `.github/workflows/trigger-publish.yml`: Replaced tibdex/github-app-token with actions/create-github-app-token@v2 and converted inputs to the new action’s kebab-case names so the workflow continues generating the app token securely.
1 parent 2445cda commit d1bdd23

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

.github/workflows/trigger-docs.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,14 @@ jobs:
3232
3333
- name: Generate token
3434
id: generate_token
35-
uses: actions/create-github-app-token@v1
35+
uses: actions/create-github-app-token@v2
3636
with:
3737
app-id: ${{ secrets.TEMPORAL_CICD_APP_ID }}
3838
private-key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }}
3939
owner: ${{ github.repository_owner }}
40-
repositories: documentation # generate a token with permissions to trigger GHA in documentation repo
40+
# Generate a token with permissions to trigger GHA in documentation repo.
41+
repositories: |
42+
documentation
4143
4244
- name: Trigger Documentation Workflow
4345
env:

.github/workflows/trigger-publish.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,14 @@ jobs:
1818
steps:
1919
- name: Generate a token
2020
id: generate_token
21-
uses: tibdex/github-app-token@b62528385c34dbc9f38e5f4225ac829252d1ea92
21+
uses: actions/create-github-app-token@v2
2222
with:
23-
app_id: ${{ secrets.TEMPORAL_CICD_APP_ID }}
24-
private_key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }}
23+
app-id: ${{ secrets.TEMPORAL_CICD_APP_ID }}
24+
private-key: ${{ secrets.TEMPORAL_CICD_PRIVATE_KEY }}
25+
owner: temporalio
26+
repositories: |
27+
cli
28+
docker-builds
2529
2630
- name: Dispatch docker builds Github Action
2731
env:

0 commit comments

Comments
 (0)