Skip to content

Conversation

@infernus01
Copy link
Contributor

@infernus01 infernus01 commented Aug 14, 2025

Changes

Fixes #8904

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Update examples and documentation to use ArtifactHub instead of the deprecated Tekton Hub for resource discovery and management.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 14, 2025
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 14, 2025
@infernus01
Copy link
Contributor Author

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 14, 2025
@infernus01
Copy link
Contributor Author

I guess none of the failing CI should affect the hub resolver's internal behavior or error message formatting.

@afrittoli
Copy link
Member

/retest

1 similar comment
@waveywaves
Copy link
Member

/retest

Copy link
Member

@waveywaves waveywaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
Copy link
Member

@aThorp96 aThorp96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@infernus01 I think the commit-message/PR-title should be docs: Switch from deprecated Tekton Hub to ArtifactHub. IDK if we have any automation that references the commit title, but IIUC it should follow conventional commits and migrate isn't a documented commit type. It might also suggest that the commit includes breaking changes

@tekton-robot
Copy link
Collaborator

@aThorp96: changing LGTM is restricted to collaborators

In response to this:

/lgtm

@infernus01 I think the commit-message/PR-title should be docs: Switch from deprecated Tekton Hub to ArtifactHub. IDK if we have any automation that references the commit title, but IIUC it should follow conventional commits and migrate isn't a documented commit type. It might also suggest that the commit includes breaking changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@infernus01 infernus01 changed the title migrate: Switch from deprecated Tekton Hub to ArtifactHub docs: Switch from deprecated Tekton Hub to ArtifactHub Aug 20, 2025
@infernus01
Copy link
Contributor Author

@infernus01 I think the commit-message/PR-title should be docs: Switch from deprecated Tekton Hub to ArtifactHub. IDK if we have any automation that references the commit title, but IIUC it should follow conventional commits and migrate isn't a documented commit type. It might also suggest that the commit includes breaking changes

thanks, makes sense, did the changes!

@waveywaves
Copy link
Member

waveywaves commented Aug 20, 2025

@infernus01 the commit message seems to be the same, I am guessing you will have to git amend the commit message title, the commit message is more important than the PR name itself :) You will have to change and force push

@waveywaves
Copy link
Member

I can lgtm once the update is done

Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
@infernus01 infernus01 force-pushed the doc/hub-to-artifact branch from c9e5fe9 to 06c44ab Compare August 20, 2025 14:13
Copy link
Member

@waveywaves waveywaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a final question ig, apologies for the delay

params:
- name: url
value: https://api.hub.tekton.dev/v1/resource/tekton/task/git-clone/0.10/raw
value: https://raw.githubusercontent.com/tektoncd/catalog/main/task/git-clone/0.10/git-clone.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why aren't we using the artifact hub https://artifacthub.io/packages/tekton-task/tekton-catalog-tasks/git-clone task here ? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm I guessed artifact didn't provide raw content APIs, doest it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The raw content API doesn't simply return the yaml file, which would be required for the http resolver to work. The API will return the raw package, from https://artifacthub.io/api/v1/packages/tekton-task/tekton-catalog-tasks/git-clone, but there isn't an obvious way I don't think to retrieve the manifest using just an http request

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be captured in an issue so we can use links from artifact hub directly ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs to be, since these are examples for the http resolver and only used the tekton hub's raw endpoint coincidentally. The hub resolver can reference artifact hub directly

params:
- name: url
value: https://api.hub.tekton.dev/v1/resource/tekton/task/git-clone/0.10/raw
value: https://raw.githubusercontent.com/tektoncd/catalog/main/task/git-clone/0.10/git-clone.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why aren't we using the artifact hub https://artifacthub.io/packages/tekton-task/tekton-catalog-tasks/git-clone task here ? 🤔

@tekton-robot tekton-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025
@infernus01
Copy link
Contributor Author

/retest

@tekton-robot
Copy link
Collaborator

@infernus01: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester
Copy link
Member

/retest

@infernus01 infernus01 requested a review from waveywaves August 21, 2025 09:45
@waveywaves
Copy link
Member

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aThorp96, waveywaves

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@waveywaves
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2025
@tekton-robot tekton-robot merged commit 639c79d into tektoncd:main Aug 22, 2025
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Switch from Tekton Hub to Artifacthub in examples and docs.

6 participants