-
Couldn't load subscription status.
- Fork 1.8k
docs: Switch from deprecated Tekton Hub to ArtifactHub #8967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/kind documentation |
|
I guess none of the failing CI should affect the hub resolver's internal behavior or error message formatting. |
|
/retest |
1 similar comment
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@infernus01 I think the commit-message/PR-title should be docs: Switch from deprecated Tekton Hub to ArtifactHub. IDK if we have any automation that references the commit title, but IIUC it should follow conventional commits and migrate isn't a documented commit type. It might also suggest that the commit includes breaking changes
|
@aThorp96: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
thanks, makes sense, did the changes! |
|
@infernus01 the commit message seems to be the same, I am guessing you will have to git amend the commit message title, the commit message is more important than the PR name itself :) You will have to change and force push |
|
I can lgtm once the update is done |
Signed-off-by: Shubham Bhardwaj <shubbhar@redhat.com>
c9e5fe9 to
06c44ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a final question ig, apologies for the delay
| params: | ||
| - name: url | ||
| value: https://api.hub.tekton.dev/v1/resource/tekton/task/git-clone/0.10/raw | ||
| value: https://raw.githubusercontent.com/tektoncd/catalog/main/task/git-clone/0.10/git-clone.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why aren't we using the artifact hub https://artifacthub.io/packages/tekton-task/tekton-catalog-tasks/git-clone task here ? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm I guessed artifact didn't provide raw content APIs, doest it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The raw content API doesn't simply return the yaml file, which would be required for the http resolver to work. The API will return the raw package, from https://artifacthub.io/api/v1/packages/tekton-task/tekton-catalog-tasks/git-clone, but there isn't an obvious way I don't think to retrieve the manifest using just an http request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need to be captured in an issue so we can use links from artifact hub directly ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it needs to be, since these are examples for the http resolver and only used the tekton hub's raw endpoint coincidentally. The hub resolver can reference artifact hub directly
| params: | ||
| - name: url | ||
| value: https://api.hub.tekton.dev/v1/resource/tekton/task/git-clone/0.10/raw | ||
| value: https://raw.githubusercontent.com/tektoncd/catalog/main/task/git-clone/0.10/git-clone.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why aren't we using the artifact hub https://artifacthub.io/packages/tekton-task/tekton-catalog-tasks/git-clone task here ? 🤔
|
/retest |
|
@infernus01: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aThorp96, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Changes
Fixes #8904
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes