[release-v1.0.x] fix(#8940): token-authentication header typo in git resolver #8947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header specified for the git resolver's http auth contained a typo leading to authentication tokens not being properly sent to the remote. Additionally, this change fixes the outdated token-authenticated git resolver example and adds an e2e regression test for authenticated git cloning. Resolves: tektoncd#8940 Resolves: https://issues.redhat.com/browse/SRVKP-8260
tekton-robot
added
do-not-merge/release-note-label-needed
7 tasks
|
/kind bug |
tekton-robot
added
release-note
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an
automatedcherry-pick of #8937/assign waveywaves
The automated cherry-pick includes a change which is incompatible with the go version of v1.0 (Go v1.23). This change includes the cherry-pick and a patch commit to resolve the go-version compatibility, since I cannot push to the automated cherry-pick branch in tekton-robot's fork
Supersedes #8941