-
Couldn't load subscription status.
- Fork 1.8k
[release-v1.0.x] fix(#8940): token-authentication header typo in git resolver #8941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.0.x] fix(#8940): token-authentication header typo in git resolver #8941
Conversation
The header specified for the git resolver's http auth contained a typo leading to authentication tokens not being properly sent to the remote. Additionally, this change fixes the outdated token-authenticated git resolver example and adds an e2e regression test for authenticated git cloning. Resolves: tektoncd#8940 Resolves: https://issues.redhat.com/browse/SRVKP-8260
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind bug |
|
/retest |
1 similar comment
|
/retest |
|
lint issues are possibly happening here because the changes from #8942 aren't present cc @vdemeester |
|
t.Context() was added in golang 1.24 so to have this change we will have to update the go version to 1.24 for this branch as well. Just updating the CI won't help. |
|
@aThorp96 could you look into this ? |
|
@waveywaves I can't seem to push to tekton-robot's fork branch or even create a PR to their fork so I created a separate cherry-pick PR with the go-version compatibility fix. This PR can be closed in favor of #8947 |
|
@tekton-robot: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #8937
/assign waveywaves