Skip to content

Conversation

@tekton-robot
Copy link
Collaborator

This is an automated cherry-pick of #8937

/assign waveywaves

Bug fix: Before this change, there was a regression in which the git resolver was not authenticating with the provided `gitToken` and `gitTokenKey`, breaking the git resolver's http token-based auth. After this change, all git operations performed by the git resolver use the provided `gitToken` for remote authentication.

The header specified for the git resolver's http auth contained a typo
leading to authentication tokens not being properly sent to the remote.

Additionally, this change fixes the outdated token-authenticated git
resolver example and adds an e2e regression test for authenticated git
cloning.

Resolves: tektoncd#8940
Resolves: https://issues.redhat.com/browse/SRVKP-8260
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 4, 2025
@tekton-robot
Copy link
Collaborator Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 4, 2025
@vdemeester
Copy link
Member

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 4, 2025
@vdemeester
Copy link
Member

/retest

1 similar comment
@waveywaves
Copy link
Member

/retest

@waveywaves
Copy link
Member

lint issues are possibly happening here because the changes from #8942 aren't present

cc @vdemeester

@waveywaves
Copy link
Member

t.Context() was added in golang 1.24 so to have this change we will have to update the go version to 1.24 for this branch as well. Just updating the CI won't help.

@waveywaves
Copy link
Member

@aThorp96 could you look into this ?

@aThorp96
Copy link
Member

aThorp96 commented Aug 5, 2025

@waveywaves I can't seem to push to tekton-robot's fork branch or even create a PR to their fork so I created a separate cherry-pick PR with the go-version compatibility fix. This PR can be closed in favor of #8947

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2025
@tekton-robot
Copy link
Collaborator Author

@tekton-robot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vdemeester vdemeester closed this Aug 5, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Tekton Community Roadmap Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants