Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose chains metrics in openshift operator for monitoring #1954

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

sudhishmk
Copy link
Contributor

@sudhishmk sudhishmk commented Jan 30, 2024

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 30, 2024
@tekton-robot
Copy link
Contributor

Hi @sudhishmk. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2024
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2024
@khrm
Copy link
Contributor

khrm commented Jan 31, 2024

Please remove the draft from this.

@sudhishmk sudhishmk marked this pull request as ready for review January 31, 2024 04:55
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@sudhishmk
Copy link
Contributor Author

Please remove the draft from this.

Done

Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2024
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 1, 2024
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@jkandasa
Copy link
Member

jkandasa commented Feb 1, 2024

thanks @sudhishmk 🎉

@jkandasa
Copy link
Member

jkandasa commented Feb 1, 2024

/retest

@piyush-garg
Copy link
Contributor

I am not sure if role and role binding is needed, is not only service monitor will do the job ?

@sudhishmk
Copy link
Contributor Author

I am not sure if role and role binding is needed, is not only service monitor will do the job ?

did you mean that since we already have role and rolebinding defined for pipeline/ trigger monitoring service, new role and role binding is not needed?

@piyush-garg
Copy link
Contributor

I am not sure if role and role binding is needed, is not only service monitor will do the job ?

did you mean that since we already have role and rolebinding defined for pipeline/ trigger monitoring service, new role and role binding is not needed?

Yes, we can even remove for triggers too, and keep single

@sudhishmk
Copy link
Contributor Author

I am not sure if role and role binding is needed, is not only service monitor will do the job ?

did you mean that since we already have role and rolebinding defined for pipeline/ trigger monitoring service, new role and role binding is not needed?

Yes, we can even remove for triggers too, and keep single

Done.

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
@tekton-robot tekton-robot merged commit 27c34dc into tektoncd:main Feb 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceMonitor for chains needed
7 participants