-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose chains metrics in openshift operator for monitoring #1954
Conversation
Hi @sudhishmk. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Please remove the draft from this. |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
cmd/openshift/operator/kodata/openshift-monitoring/02-chains-monitoring.yaml
Outdated
Show resolved
Hide resolved
dc46b34
to
eb9179d
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkandasa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks @sudhishmk 🎉 |
/retest |
I am not sure if role and role binding is needed, is not only service monitor will do the job ? |
did you mean that since we already have role and rolebinding defined for pipeline/ trigger monitoring service, new role and role binding is not needed? |
Yes, we can even remove for triggers too, and keep single |
6b3192b
to
516916c
Compare
Done. |
/lgtm |
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lint
before submitting a PRSee the contribution guide for more details.
Release Notes