Add metrics for count chains attestation for issue#1028

[sudhishmk]

Changes -: Work In Progress

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Has Docs included if any changes are user facing
• Has Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
• Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: sudhishmk / name: Sudhish Nair (b69a421, 82f745a)

[tekton-robot]

Hi @sudhishmk. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[khrm]

/ok-to-test

[khrm]

@sudhishmk Please sign he cla.

[khrm]

You can call metrics counter here:

chains/pkg/chains/signing.go

Line 174 in 592410c

if err != nil {

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerunmetrics/injection.go	Do not exist	10.0%
pkg/pipelinerunmetrics/metrics.go	Do not exist	0.0%
pkg/taskrunmetrics/injection.go	Do not exist	10.0%
pkg/taskrunmetrics/metrics.go	Do not exist	0.0%

[khrm]

Please import fake metrics like this:
_ "github.com/tektoncd/chains/pkg/pipelinerunmetrics/fake" // Make sure the pipelinerunmetrics are setup

This will ensure that unit tests are passed.

[khrm]

Add the above line in the import of following files:

1. pkg/reconciler/pipelinerun/pipelinerun_test.go
2. pkg/reconciler/taskrun/taskrun_test.go

[khrm]

/test pull-tekton-chains-integration-tests

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/signing.go	73.7%	75.7%	1.9
pkg/pipelinerunmetrics/injection.go	Do not exist	70.0%
pkg/pipelinerunmetrics/metrics.go	Do not exist	55.2%
pkg/taskrunmetrics/injection.go	Do not exist	70.0%
pkg/taskrunmetrics/metrics.go	Do not exist	55.6%

[lcarva]

Overall, this seems reasonable. My main concern here is the amount of log messages being produced when each metric is recorded.

I left various comments on the pipelinerunmetrics which also apply to the taskrunmetrics.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/signing.go	73.7%	75.7%	1.9
pkg/pipelinerunmetrics/injection.go	Do not exist	70.0%
pkg/pipelinerunmetrics/metrics.go	Do not exist	84.0%
pkg/taskrunmetrics/injection.go	Do not exist	70.0%
pkg/taskrunmetrics/metrics.go	Do not exist	86.4%

[lcarva]

@khrm, I see some comments have not yet been addressed. (GitHub collapsed some of them. You'll have to click on "Load more")

[khrm]

It was Holiday in India today. That's why @sudhishmk didn't get time I think.

Sudhish, please address them.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/signing.go	73.7%	75.2%	1.5
pkg/pipelinerunmetrics/injection.go	Do not exist	70.0%
pkg/pipelinerunmetrics/metrics.go	Do not exist	84.0%
pkg/taskrunmetrics/injection.go	Do not exist	70.0%
pkg/taskrunmetrics/metrics.go	Do not exist	86.4%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/signing.go	73.7%	74.3%	0.5
pkg/pipelinerunmetrics/injection.go	Do not exist	70.0%
pkg/pipelinerunmetrics/metrics.go	Do not exist	84.0%
pkg/taskrunmetrics/injection.go	Do not exist	70.0%
pkg/taskrunmetrics/metrics.go	Do not exist	86.4%

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/signing.go	73.7%	74.3%	0.5
pkg/pipelinerunmetrics/injection.go	Do not exist	70.0%
pkg/pipelinerunmetrics/metrics.go	Do not exist	84.6%
pkg/taskrunmetrics/injection.go	Do not exist	70.0%
pkg/taskrunmetrics/metrics.go	Do not exist	84.0%

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lcarva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lcarva]

/lgtm

[savitaashture]

Hi @sudhishmk 👋

Is it possible to update metrics doc https://github.com/tektoncd/chains/blob/main/docs/metrics.md so that we will have all the details of the metrics which chains support today
I reviewed PR yesterday but forgot to add comments

[sudhishmk]

Hi @sudhishmk 👋

Is it possible to update metrics doc https://github.com/tektoncd/chains/blob/main/docs/metrics.md so that we will have all the details of the metrics which chains support today I reviewed PR yesterday but forgot to add comments

Sure, will do that.

[sudhishmk]

Hi @sudhishmk 👋

Is it possible to update metrics doc https://github.com/tektoncd/chains/blob/main/docs/metrics.md so that we will have all the details of the metrics which chains support today I reviewed PR yesterday but forgot to add comments

Created PR for docs.