-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define a "plugin registry" class #1873
Conversation
5abb3fd
to
fd333ef
Compare
fd333ef
to
c3bdbf9
Compare
c06d64d
to
23222bb
Compare
23222bb
to
8924418
Compare
843d30d
to
be83a35
Compare
be83a35
to
4a1d86a
Compare
47d5143
to
f720ccc
Compare
f720ccc
to
05b5746
Compare
956f46f
to
73851e1
Compare
5a4f3c9
to
b9ab7f5
Compare
Downstream patch has been submitted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thanks! Just two minor nitpicks.
b9ab7f5
to
df36f3d
Compare
The class is fairly trivial, but draws a clear distinction between an arbitrary dictionary and a "plugin registry" object. New types of plugins are heading our way, therefore making boundaries more visible, to clear up responsibilities.
df36f3d
to
8613691
Compare
Updated |
tmt/-/merge_requests/82 for those interested. Edit: And Milos was faster with his /81 so I merged that instead. |
The class is fairly trivial, but draws a clear distinction between an arbitrary dictionary and a "plugin registry" object. New types of plugins are heading our way, therefore making boundaries more visible, to clear up responsibilities.
Part of the effort behind #1838 and #216.