Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update handlebars and remove cookie-parser #52

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Update handlebars and remove cookie-parser #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ var express = require('express');
var bodyParser = require('body-parser');
var methodOverride = require('method-override');
var morgan = require('morgan');
var cookieParser = require('cookie-parser');

var mongoose = require('mongoose');
var port = process.env.PORT || 3000;
Expand All @@ -22,7 +21,6 @@ var app = express();
mongoose.connect(database);

app.use(morgan('dev'));
app.use(cookieParser());

app.use(bodyParser.urlencoded({
extended: true
Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"bcrypt-nodejs": "0.0.3",
"body-parser": "^1.8.4",
"bower": "^1.8.0",
"cookie-parser": "~1.3.2",
"dotenv": "^1.2.0",
"email-templates": "^2.0.1",
"express": "^4.9.8",
Expand All @@ -20,7 +19,7 @@
"gulp-sass": "^2.3.2",
"gulp-sourcemaps": "^1.12.0",
"gulp-uglify": "^1.5.4",
"handlebars": "^3.0.3",
"handlebars": "^4.0.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even use handlebars in this project anywhere..?

Copy link
Contributor Author

@patins patins Jan 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially I tried removing it and thought it worked (the word "handlebars" isn't used anywhere in the source), but it's used by a mailer that doesn't declare it as a dependency :(

"jsonwebtoken": "5.0.4",
"method-override": "^2.3.5",
"moment": "^2.10.3",
Expand Down