Update handlebars and remove cookie-parser #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old handlebars version had a CVE, GitHub was loud. Removing cookie-parser because we don't use cookies.
ehzhang
reviewed
Jan 18, 2018
| @@ -20,7 +19,7 @@ | |||
| "gulp-sass": "^2.3.2", | |||
| "gulp-sourcemaps": "^1.12.0", | |||
| "gulp-uglify": "^1.5.4", | |||
| "handlebars": "^3.0.3", | |||
| "handlebars": "^4.0.11", | |||
There was a problem hiding this comment.
Do we even use handlebars in this project anywhere..?
There was a problem hiding this comment.
Initially I tried removing it and thought it worked (the word "handlebars" isn't used anywhere in the source), but it's used by a mailer that doesn't declare it as a dependency :(
prabhanshuguptagit
pushed a commit
to prabhanshuguptagit/quill
that referenced
this pull request
Jan 23, 2019
Update handlebars and remove cookie-parser
jtviolet
pushed a commit
to jtviolet/fountain
that referenced
this pull request
Aug 13, 2019
Update handlebars and remove cookie-parser
jtviolet
pushed a commit
to jtviolet/fountain
that referenced
this pull request
Aug 13, 2019
Update handlebars and remove cookie-parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old handlebars version had a CVE, GitHub was loud. Removing cookie-parser because we don't use cookies.