[TEC-75] Refactor Security Group Module: Module Rename, VPC ID Parameter, and Egress Variables #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le, and introduced egress variables.
…le, and introduced egress variables.
[TEC-75]
techiescamp
pushed a commit
that referenced
this pull request
Sep 5, 2023
Merge branch 'techiescamp:master' into gitlab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several refactoring changes to the Security Group module. The following updates have been made:
Module Rename:
The module name has been changed from 'ec2-sg' to 'security-group' to enhance clarity and conformity with naming conventions.
Add vpc_id Parameter:
A new parameter named 'vpc_id' has been introduced to the module. This allows the creation of security groups for different VPCs by providing the respective VPC ID.
Convert Egress Rule to Variables:
The egress rule in the module has been refactored to use variables for egress ports, protocol, and CIDR blocks. This enhancement provides greater flexibility in defining egress rules according to specific requirements.
Fixes #12