Merge pull request #13 from arunlalp/master

[TEC-75] Refactor Security Group Module: Module Rename, VPC ID Parameter, and Egress Variables

Author: techiescamp

README.md

@@ -27,6 +27,44 @@ terraform apply -var-file=../../../vars/dev/rds.tfvars
 
 terraform destroy -var-file=../../../vars/dev/rds.tfvars
 
+## Terraform EC2 Instance Deployment
+
+1. Navigate to the `environment/dev` folder:
+
+```bash
+cd environment/dev
+```
+
+2. Open the `ec2.tfvars` file and modify it with your desired details. This file contains variables used in the Terraform configuration.
+
+## Deployment
+
+1. Initialize Terraform in the working directory:
+
+```bash
+terraform init
+```
+
+2. Create an execution plan:
+
+```bash
+terraform plan -var-file=../../../vars/dev/ec2.tfvars
+```
+
+3. Apply the changes to create the EC2 instance:
+
+```bash
+terraform apply -var-file=../../../vars/dev/ec2.tfvars
+```
+
+4. To destroy the EC2 instance and associated resources:
+
+```bash
+terraform destroy -var-file=../../../vars/dev/ec2.tfvars
+```
+
+**Note**: Always review the execution plan (`terraform plan`) before applying changes to avoid unintended modifications.
+
 ## Command Reference
 
 Update all outputs:
@@ -39,5 +77,3 @@ Show all outputs:
 
 
 
-
-

environments/dev/ec2/main.tf

@@ -16,21 +16,26 @@ module "ec2" {
   owner              = var.owner
   cost_center        = var.cost_center
   application        = var.application
-  security_group_ids = module.ec2-sg.security_group_ids
+  security_group_ids = module.security-group.security_group_ids
 }
 
-module "ec2-sg" {
-  source      = "../../../modules/ec2-sg"
-  region      = var.region
-  tags        = var.tags
-  name        = var.name
-  environment = var.environment
-  owner       = var.owner
-  cost_center = var.cost_center
-  application = var.application
-  sg_name     = var.sg_name
-  from_port   = var.from_port
-  to_port     = var.to_port
-  protocol    = var.protocol
-  cidr_block  = var.cidr_block
+module "security-group" {
+  source             = "../../../modules/security-group"
+  region             = var.region
+  tags               = var.tags
+  name               = var.name
+  environment        = var.environment
+  owner              = var.owner
+  cost_center        = var.cost_center
+  application        = var.application
+  sg_name            = var.sg_name
+  vpc_id             = var.vpc_id
+  ingress_from_port  = var.ingress_from_port
+  ingress_to_port    = var.ingress_to_port
+  ingress_protocol   = var.ingress_protocol
+  ingress_cidr_block = var.ingress_cidr_block
+  egress_from_port   = var.egress_from_port
+  egress_to_port     = var.egress_to_port
+  egress_protocol    = var.egress_protocol
+  egress_cidr_block  = var.egress_cidr_block
 }

environments/dev/ec2/variables.tf

@@ -1,77 +1,102 @@
 variable "region" {
   type        = string
-  description = "Region of the ec2 instance"
+  description = "Region of the EC2 instance"
 }
 
 variable "instance_name" {
   type        = string
-  description = "Name of the ec2 instance"
+  description = "Name of the EC2 instance"
 }
 
 variable "ami_id" {
   type        = string
-  description = "AMI Id of the ec2 instance"
+  description = "AMI ID of the EC2 instance"
 }
 
 variable "instance_type" {
   type        = string
-  description = "Instance type of the ec2 instance"
+  description = "Instance type of the EC2 instance"
 }
 
 variable "key_name" {
   type        = string
-  description = "Key name of the ec2 instance"
+  description = "Key name of the EC2 instance"
 }
 
 variable "instance_count" {
   type        = number
-  description = "Count of the ec2 instances"
+  description = "Count of the EC2 instances"
 }
 
 variable "subnet_ids" {
   type        = list(string)
-  description = "Subnet ids of the ec2 instance"
+  description = "Subnet IDs of the EC2 instance"
 }
 
 variable "sg_name" {
   type        = string
-  description = "Security group for instance"
+  description = "Security group name for the instance"
 }
 
-variable "cidr_block" {
+variable "vpc_id" {
+  type        = string
+  description = "VPC ID for the security group"
+}
+
+variable "ingress_cidr_block" {
   type        = list(string)
-  description = "CIDR block for EC2 security group"
+  description = "CIDR blocks for EC2 security group ingress rules"
 }
 
-variable "from_port" {
+variable "ingress_from_port" {
   description = "The starting port for ingress rules"
   type        = list(number)
 }
 
-variable "to_port" {
+variable "ingress_to_port" {
   description = "The ending port for ingress rules"
   type        = list(number)
 }
 
-variable "protocol" {
+variable "ingress_protocol" {
   description = "The protocol for ingress rules"
+  type        = list(any)
+}
+
+variable "egress_cidr_block" {
   type        = list(string)
+  description = "CIDR blocks for EC2 security group egress rules"
+}
+
+variable "egress_from_port" {
+  description = "The starting port for egress rules"
+  type        = list(number)
+}
+
+variable "egress_to_port" {
+  description = "The ending port for egress rules"
+  type        = list(number)
+}
+
+variable "egress_protocol" {
+  description = "The protocol for egress rules"
+  type        = list(any)
 }
 
 variable "tags" {
   default     = {}
   type        = map(string)
-  description = "Extra tags to attach to the ec2-sg resources"
+  description = "Extra tags to attach to the security group resources"
 }
 
 variable "name" {
   type        = string
-  description = "The name of the resources."
+  description = "The name of the resources"
 }
 
 variable "environment" {
   type        = list(string)
-  description = "The environment name for the resources."
+  description = "The environment name for the resources"
 }
 
 variable "owner" {
@@ -81,10 +106,10 @@ variable "owner" {
 
 variable "cost_center" {
   type        = string
-  description = "Cost center identifier for the resource."
+  description = "Cost center identifier for the resource"
 }
 
 variable "application" {
   type        = string
-  description = "Name of the application related to the resource."
-}
+  description = "Name of the application related to the resource"
+}

modules/ec2-sg/main.tf

@@ -0,0 +1,37 @@
+resource "aws_security_group" "instance_sg" {
+  name        = var.sg_name
+  description = "Security Group for Instance"
+  vpc_id      = var.vpc_id
+
+  dynamic "ingress" {
+    for_each = toset(range(length(var.ingress_from_port)))
+    content {
+      from_port   = var.ingress_from_port[ingress.key]
+      to_port     = var.ingress_to_port[ingress.key]
+      protocol    = var.ingress_protocol[ingress.key]
+      cidr_blocks = var.ingress_cidr_block
+    }
+  }
+
+  dynamic "egress" {
+    for_each = toset(range(length(var.egress_from_port)))
+    content {
+      from_port   = var.egress_from_port[egress.key]
+      to_port     = var.egress_to_port[egress.key]
+      protocol    = var.egress_protocol[egress.key]
+      cidr_blocks = var.egress_cidr_block
+    }
+  }
+
+  tags = merge(
+    {
+      "Name"        = "${var.name}-sg"
+      "Environment" = var.environment[0]
+      "Owner"       = var.owner
+      "CostCenter"  = var.cost_center
+      "Application" = var.application
+    },
+    var.tags
+  )
+
+}